fix varlock executable finding logic on windows (#204)

Author: theoephraim

.changeset/nine-hoops-cough.md

@@ -0,0 +1,5 @@
+---
+"varlock": patch
+---
+
+fix logic around finding the varlock executable to work with windows .cmd files

packages/utils/src/git-utils.ts

@@ -6,8 +6,15 @@ export async function checkIsFileGitIgnored(path: string, warnIfNotGitRepo = fal
     return true;
   } catch (err) {
     const stderr = (err as any).stderr as string;
-    // git is not installed, so we don't know
-    if ((err as any).status === 127 || stderr.includes('not found')) return undefined;
+    // git is not installed, so we can't check
+    if (
+      (err as any).status === 127
+      || stderr.includes('not found')
+      || stderr.includes('not recognized') // windows
+    ) {
+      return undefined;
+    }
+
     // other file related issues could throw this
     if ((err as any).code === 'ENOENT') return undefined;
     // `git check-ignore -q` exits with code 1 but no other error if is not ignored

packages/varlock/src/lib/exec-sync-varlock.ts

@@ -1,11 +1,16 @@
 import path from 'node:path';
 import fs from 'node:fs';
+import os from 'node:os';
 import { execSync } from 'node:child_process';
 
 // weird tsup issue using `typeof execSync` from node:child_process
 // see https://github.com/egoist/tsup/issues/1367
 import type { execSync as execSyncType } from 'child_process';
 
+const platform = os.platform();
+const isWindows = platform.match(/^win/i);
+
+
 /**
  * small helper to call execSync and call the varlock cli
  *
@@ -30,8 +35,9 @@ export function execSyncVarlock(
       });
       return result.toString();
     } catch (err) {
-      // code 127 means not found
-      if ((err as any).status !== 127) throw err;
+      // code 127 means not found (on linux only)
+      if (!isWindows && (err as any).status !== 127) throw err;
+      // on windows, we'll just do the extra checks anyway
     }
 
     // if varlock was not found, it either means it is not installed
@@ -47,8 +53,6 @@ export function execSyncVarlock(
             ...opts,
             stdio: 'pipe',
           });
-          // const commandArgs = command.split(' ').filter(Boolean);
-          // const result = execFileSync(possibleVarlockPath, commandArgs, opts);
           return result.toString();
         } else {
           throw new Error('Unable to find varlock executable');