Feature/ask approval file invalidation (#1002)

juanpablosalas · web-flow · commit b4aae8382b35 · 2026-02-13T11:06:42.000-06:00
* fixed issue preventing sending alerts

* fixed email settings

* Latest email formatting changes
diff --git a/DMOps/file_invalidation_server/fi_manager/utils.py b/DMOps/file_invalidation_server/fi_manager/utils.py
@@ -61,18 +61,18 @@ def send_approval_alert(request_id):
         <body>
             <h2>A new file invalidation request has been submitted and awaits approval</h2>
 
-            <p><b>Request ID:</b> {request_id}</p>
-            <p><b>Reason:</b> {reason}</p>
-            <p><b>Mode:</b> {mode}</p>
-            <p><b>RSE:</b> {rse}</p>
-            <p><b>Dry run:</b> {dry_run}</p>
-            <p><b>Requested by:</b> {request_user}</p>
-            <p><b>Number of files:</b> {count}</p>
-            <p><b>Contains /RAW/?:</b> {contains_raw}</p>
-
-            <p><b>File names:</b></p>
+            <p><b>Request ID:</b> <a href="https://file-invalidation.app.cern.ch/api/approve/{request_id}"> {request_id} </a> <br>
+            <b>Reason:</b> {reason}<br>
+            <b>Mode:</b> {mode}<br>
+            <b>RSE:</b> {rse}<br>
+            <b>Dry run:</b> {dry_run}<br>
+            <b>Requested by:</b> {request_user}<br>
+            <b>Number of files:</b> {count}<br>
+            <b>Contains /RAW/?:</b> {contains_raw}</p>
+
+            <p><b>File names preview (up to 10 files):</b></p>
             <ul>
-            {''.join(f"<li>{f.file_name}</li>" for f in files)}
+            {''.join(f"<li>{f.file_name}</li>" for f in files[:10])}
             </ul>
         </body>
         </html>
diff --git a/DMOps/file_invalidation_server/file_invalidation_server/settings.py b/DMOps/file_invalidation_server/file_invalidation_server/settings.py
@@ -76,7 +76,7 @@
 
 EMAIL_USE_TLS = False
 EMAIL_USE_SSL = False
-ADMIN_EMAILS = ['juan.pablo.salas.galindo@cern.ch','christos.emmanouil@cern.ch','h.ozturk@cern.ch','panos.paparrigopoulos@cern.ch'] #cms-comp-ops-transfer-team@cern.ch
+ADMIN_EMAILS = ['cms-dm-ops-core-team@cern.ch'] #cms-comp-ops-transfer-team@cern.ch
 
 ROOT_URLCONF = 'file_invalidation_server.urls'
 
