Skip to content

Commit 747c70a

Browse files
authored
Merge pull request #11489 from anehnis/patch-1
Resolve Issue #11367
2 parents fea1de4 + f99df70 commit 747c70a

1 file changed

Lines changed: 1 addition & 15 deletions

File tree

src/python/WMCore/MicroService/MSRuleCleaner/MSRuleCleaner.py

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -302,20 +302,6 @@ def _dispatchWflow(self, wflow):
302302
msg = "Skipping cleanup step for workflow: %s - RequestType is %s."
303303
msg += " Will try to archive it directly."
304304
self.logger.info(msg, wflow['RequestName'], wflow['RequestType'])
305-
elif wflow['RequestStatus'] in ['rejected', 'aborted-completed']:
306-
# NOTE: We do not check the ParentageResolved flag for these
307-
# workflows, but we do need to clean output data placement
308-
# rules from the agents for them
309-
for pline in self.agentlines:
310-
try:
311-
pline.run(wflow)
312-
except Exception as ex:
313-
msg = "%s: General error from pipeline. Workflow: %s. Error: \n%s. "
314-
msg += "\nWill retry again in the next cycle."
315-
self.logger.exception(msg, pline.name, wflow['RequestName'], str(ex))
316-
continue
317-
if wflow['CleanupStatus'][pline.name]:
318-
self.wfCounters['cleaned'][pline.name] += 1
319305
elif wflow['RequestStatus'] == 'announced' and not wflow['ParentageResolved']:
320306
# NOTE: We skip workflows which are not having 'ParentageResolved'
321307
# flag, but we still need some proper logging for them.
@@ -340,7 +326,7 @@ def _dispatchWflow(self, wflow):
340326
msg += " Will retry again in the next cycle."
341327
self.logger.info(msg)
342328
self.alertStatusAdvanceExpired(wflow, additionalInfo=msg)
343-
elif wflow['RequestStatus'] == 'announced':
329+
elif wflow['RequestStatus'] in ['announced', 'rejected', 'aborted-completed']:
344330
for pline in self.cleanuplines:
345331
try:
346332
pline.run(wflow)

0 commit comments

Comments
 (0)