COMPUTE-1703_instance_type_selector_validation (#1511)

* COMPUTE-1703_instance_type_selector_validation

(feat) app_builder.py, test_dxpy.py - added validation for the applet build checking mutual exclusivity in the applet spec for selector and instanceType and clusterSpec

* COMPUTE-1703_instance_type_selector_validation

(feat) app_builder.py, test_dxpy.py - added regional options

Author: aogorodnikov-dna

src/python/dxpy/app_builder.py

@@ -64,12 +64,65 @@ class AppBuilderException(Exception):
     """
     pass
 
+def _validate_system_requirements(system_requirements):
+    """
+    Validates systemRequirements section of dxapp.json for instanceTypeSelector constraints.
+
+    :param system_requirements: The systemRequirements section from runSpec
+    :type system_requirements: dict
+    :raises AppBuilderException: If validation fails
+    """
+    if not isinstance(system_requirements, dict):
+        return
+
+    for entry_point, requirements in system_requirements.items():
+        if not isinstance(requirements, dict):
+            continue
+
+        has_instance_type = 'instanceType' in requirements
+        has_instance_type_selector = 'instanceTypeSelector' in requirements
+        has_cluster_spec = 'clusterSpec' in requirements
+
+        # Check mutual exclusivity: instanceType and instanceTypeSelector
+        if has_instance_type and has_instance_type_selector:
+            raise AppBuilderException(
+                "instanceType and instanceTypeSelector keywords are mutually exclusive "
+                "in systemRequirements for entry point '{}'".format(entry_point)
+            )
+
+        # Check mutual exclusivity: instanceTypeSelector and clusterSpec
+        if has_instance_type_selector and has_cluster_spec:
+            raise AppBuilderException(
+                "instanceTypeSelector and clusterSpec keywords are mutually exclusive "
+                "in systemRequirements for entry point '{}'".format(entry_point)
+            )
+
 def _validate_applet_spec(applet_spec):
     if 'runSpec' not in applet_spec:
         raise AppBuilderException("Required field 'runSpec' not found in dxapp.json")
 
+    # Validate systemRequirements for instanceTypeSelector constraints in runSpec
+    if 'systemRequirements' in applet_spec.get('runSpec', {}):
+        _validate_system_requirements(applet_spec['runSpec']['systemRequirements'])
+
+    # Validate systemRequirements in regionalOptions for each region
+    regional_options = applet_spec.get('regionalOptions', {})
+    if isinstance(regional_options, dict):
+        for region, options in regional_options.items():
+            if isinstance(options, dict) and 'systemRequirements' in options:
+                _validate_system_requirements(options['systemRequirements'])
+
 def _validate_app_spec(app_spec):
-    pass
+    # Validate systemRequirements for instanceTypeSelector constraints in runSpec
+    if 'runSpec' in app_spec and 'systemRequirements' in app_spec['runSpec']:
+        _validate_system_requirements(app_spec['runSpec']['systemRequirements'])
+
+    # Validate systemRequirements in regionalOptions for each region
+    regional_options = app_spec.get('regionalOptions', {})
+    if isinstance(regional_options, dict):
+        for region, options in regional_options.items():
+            if isinstance(options, dict) and 'systemRequirements' in options:
+                _validate_system_requirements(options['systemRequirements'])
 
 def _get_applet_spec(src_dir):
     applet_spec_file = os.path.join(src_dir, "dxapp.json")