@@ -10,26 +10,27 @@ warning, the data entries do not cover all of civil time before
10101970, and undoubtedly errors remain in the code and data. Feel
1111free to fill gaps or fix mistakes, and please email improvements
1212to <tz@iana.org> for use in the future. In your email, please give
13- reliable sources that reviewers can check.
13+ reliable sources that reviewers can check. The mailing list and its
14+ archives are public, so please do not send confidential information.
1415
1516## Contributing technical changes
1617
1718To email small changes, please run a POSIX shell command like
18- ' diff -u old/europe new/europe >myfix.patch' , and attach
19- ' myfix.patch' to the email.
19+ ‘ diff -u old/europe new/europe >myfix.patch’ , and attach
20+ ‘ myfix.patch’ to the email.
2021
2122For more-elaborate or possibly controversial changes,
2223such as renaming, adding or removing zones, please read
23- " Theory and pragmatics of the tz code and data"
24+ “ Theory and pragmatics of the tz code and data”
2425<https://www.iana.org/time-zones/repository/theory.html>.
2526It is also good to browse the mailing list archives
2627<https://lists.iana.org/hyperkitty/list/tz@iana.org/>
2728for examples of patches that tend to work well.
2829Changes should contain commentary citing reliable sources.
29- Citations should use " https:" URLs if available.
30+ Citations should use ‘ https:’ URLs if available.
3031
3132For changes that fix sensitive security-related bugs, please see the
32- distribution's ' SECURITY' file.
33+ distribution’s SECURITY file.
3334
3435Please submit changes against either the latest release
3536<https://www.iana.org/time-zones> or the main branch of the development
@@ -54,11 +55,11 @@ If you use Git the following workflow may be helpful:
5455
5556 git checkout -b mybranch
5657
57- * Sleuth by using ' git blame' . For example, when fixing data for
58- Africa/Sao_Tome, if the command ' git blame africa' outputs a line
59- ' 2951fa3b (Paul Eggert 2018-01-08 09:03:13 -0800 1068) Zone
60- Africa/Sao_Tome 0:26:56 - LMT 1884' , commit 2951fa3b should
61- provide some justification for the ' Zone Africa/Sao_Tome' line.
58+ * Sleuth by using ‘ git blame’ . For example, when fixing data for
59+ Africa/Sao_Tome, if the command ‘ git blame africa’ outputs a line
60+ ‘ 2951fa3b (Paul Eggert 2018-01-08 09:03:13 -0800 1068) Zone
61+ Africa/Sao_Tome 0:26:56 - LMT 1884’ , commit 2951fa3b should
62+ provide some justification for the ‘ Zone Africa/Sao_Tome’ line.
6263
6364 * Edit source files. Include commentary that justifies the
6465 changes by citing reliable sources.
@@ -69,28 +70,31 @@ If you use Git the following workflow may be helpful:
6970 ./zdump -v America/Los_Angeles
7071
7172 Although builds assume only basic POSIX, they use extra features
72- if available. ' make check' accesses validator.w3.org unless you
73- lack ' curl' or use ' make CURL=:' . If you have the latest GCC,
74- " make CFLAGS='$(GCC_DEBUG_FLAGS)'" does extra checking.
73+ if available. ‘ make check’ accesses validator.w3.org unless you
74+ lack ‘ curl’ or use ‘ make CURL=:’ . If you have the latest GCC,
75+ ‘ make CFLAGS='$(GCC_DEBUG_FLAGS)'’ does extra checking.
7576
7677 * For each separable change, commit it in the new branch, e.g.:
7778
7879 git add northamerica
7980 git commit
8081
81- See recent ' git log' output for the commit-message style.
82+ See recent ‘ git log’ output for the commit-message style.
8283
8384 * Create patch files 0001-..., 0002-..., ...
8485
8586 git format-patch main
8687
88+ * Check that the patch files and your email setup contain only
89+ information that you want to make public.
90+
8791 * After reviewing the patch files, send the patches to <tz@iana.org>
8892 for others to review.
8993
9094 git send-email main
9195
9296 For an archived example of such an email, see
93- " [PROPOSED] Fix off-by-1 error for Jamaica and T&C before 1913"
97+ “ [PROPOSED] Fix off-by-1 error for Jamaica and T&C before 1913”
9498 <https://mm.icann.org/pipermail/tz/2018-February/026122.html>.
9599
96100 * Start anew by getting current with the main branch again
0 commit comments