sound: Remove redundant check in mixer_clone()

christosmarg · christosmarg · commit cabf76fde836 · 2025-03-12T22:15:34.000+01:00
PCM_REGISTERED() does this check through PCM_ALIVE().

Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
diff --git a/sys/dev/sound/pcm/mixer.c b/sys/dev/sound/pcm/mixer.c
@@ -1365,7 +1365,7 @@ mixer_clone(void *arg,
 		bus_topo_lock();
 		d = devclass_get_softc(pcm_devclass, snd_unit);
 		/* See related comment in dsp_clone(). */
-		if (d != NULL && PCM_REGISTERED(d) && d->mixer_dev != NULL) {
+		if (PCM_REGISTERED(d) && d->mixer_dev != NULL) {
 			*dev = d->mixer_dev;
 			dev_ref(*dev);
 		}

Original file line number	Diff line number	Diff line change
`@@ -1365,7 +1365,7 @@ mixer_clone(void *arg,`
`1365`	`1365`	`bus_topo_lock();`
`1366`	`1366`	`d = devclass_get_softc(pcm_devclass, snd_unit);`
`1367`	`1367`	`/* See related comment in dsp_clone(). */`
`1368`		`- if (d != NULL && PCM_REGISTERED(d) && d->mixer_dev != NULL) {`
	`1368`	`+ if (PCM_REGISTERED(d) && d->mixer_dev != NULL) {`
`1369`	`1369`	`*dev = d->mixer_dev;`
`1370`	`1370`	`dev_ref(*dev);`
`1371`	`1371`	`}`