color in SvgPicture

[mahdiqdi]

i used color property to change svg color.but now its deprected.how should i change my svg color

[jannisnikoy]

@mahdiqdi the docs seem to suggest using the colorFilter property instead. Wish color: remained, even if under the hood it'd use colorFilter. Feel like this is adding a lot of unnecessary code, especially when using lots of svgs 🤷

colorFilter: ColorFilter.mode(Colors.red, BlendMode.srcIn)

[mahdiqdi]

right now i am using lots of svgs as icon in my flutter app.does colorFilter decrease my performance or not?
@jannisnikoy

[felipecastrosales]

Yes, docs suggest colorFilter. But I think there could be a better Migration Guide.

[dnfield]

I would be happy to review any PRs that update the docs and/or read me to help people out with this.

Part of what I'm trying to encourage users of this API to think about is what kind of color filter they want, or whether they want to try to use the ColorMapper API instead.

[hasanmhallak]

@dnfield but why not leaving it the way it is? with these changes a lot of users will have so much code to write refactoring large code bases let alone multiple projects.

It is a good idea to encourage users to think of color filter, but this is what optional parameters all about in the first place right?

[dnfield]

The property is deprecated but still may be used. There is an easy path to migration forward to a more flexible API.

[hasanmhallak]

Thanks for the reply, I know it can still be used, but deprecation means eventually this property will be removed.

I'm just saying this is adding a lot of unnecessary code, especially when using lots of svgs. Not all developers are using the colorFilter or need to add a matrix based filters. but if someone would, a colorFilter property should override the color property.

[dnfield]

Deprecated means there's a better option. I am in no rush to remove this and am willing to keep it around for a long time to let people migrate :)

[petro-i]

Why is the development of this package makes life more difficult?
Color parameter was so easy to use, but now we have to add one more import at least to have the same functionality. I think color parameter deprecation was an error. Use case of simple "color" parameter is a lot more useful then complex "colorFilter" which is not easy to use and understand how it works in case we neeed just paint svg with single color.

[felipecastrosales]

@petro-i, if you need to use only one color, use it like this:

colorFilter: ColorFilter.mode(YOURCOLOR, BlendMode.srcIn)

Unfortunately that's it. But I understand the maintainer's explanation.

[HappyMakadiyaS]

Why color is not nullable type in ColorFilter.mode?
In my use case, having condition-based color assignment that can be nullable in many cases and earlier with colour attribute it was handled nicely. Now I have to put unnecessary null check conditions over ColorFilter.

[dnfield]

I'm going to close this issue.

The goal of deprecating color is to get users of this library to think more seriously about how and whether a color filter is right for them. Color filtering is generally more expensive than color mapping, especially for some blend modes. Color filtering also sometimes is hard to reason about if you're not familiar with the blend modes and how they work, or when and whether you should use a color matrix instead of a Porter-Duff blend.

As mentioned, I have no plans to remove the color parameter. If you want to use it, keep using it. But I think deprecating it achieves the goal of getting users to think a bit more about what kind of color filtering they want and whether they want it at all. I'd be open to improvements in documentation around this.

[petro-i]

to get users of this library to think more seriously about how and whether a color filter is right for them
sorry, but you are not teacher and we are not in school.
The idea against deprecating color is just so filter is harder to configure in everyday usage then just color, people need color in 99% of cases, it is just not time-optimal to use filter instead of color, it needs more time so in fact in 99% cases we are wasting time configuring filter == you force people to waste time using this library.