Skip to content

Commit 1464f45

Browse files
authored
Merge pull request #7098 from donker/fix-build-20260309
Fix the addition of assemblies and sql scripts to module build
2 parents 89431a0 + 6e38739 commit 1464f45

2 files changed

Lines changed: 8 additions & 11 deletions

File tree

Build/BuildScripts/Package.targets

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,12 @@
2525
from component in package.Element("components").Descendants("component")
2626
let componentType = component.Attribute("type").Value
2727
from file in component.Descendants().Descendants<XElement>(componentType.ToLowerInvariant())
28+
where file.Attribute("action")?.Value != "UnRegister"
2829
let path = file.Element("path")
2930
let name = file.Element("name")
3031
let sourceFileName = file.Element("sourceFileName")
3132
let fullFilePath = sourceFileName?.Value ?? Path.Combine(path?.Value ?? string.Empty, name.Value)
32-
select new TaskItem(fullFilePath)
33+
select new TaskItem(fullFilePath, new Dictionary<string, object> { { "RecursiveDir", Path.GetDirectoryName(fullFilePath) }, })
3334
).ToArray();
3435
]]>
3536
</Code>
@@ -46,7 +47,7 @@
4647
<Output TaskParameter="Value" PropertyName="Version" />
4748
</XmlRead>
4849
<ExtensionPackager Manifest="$(DNNFileName).dnn" WorkingFolder="$(MSBuildProjectDirectory)\">
49-
<Output TaskParameter="PackageFiles" PropertyName="PackageFiles">
50+
<Output TaskParameter="PackageFiles" ItemName="PackageFiles">
5051
</Output>
5152
</ExtensionPackager>
5253

@@ -58,19 +59,20 @@
5859
<LicenseFiles Include="license.txt"/>
5960
</ItemGroup>
6061
<Copy SourceFiles="@(LicenseFiles)" DestinationFolder="$(MSBuildProjectDirectory)\Package" />
62+
6163
<ItemGroup>
6264
<ReleaseNotesFiles Include="releaseNotes.txt"/>
6365
</ItemGroup>
6466
<Copy SourceFiles="@(ReleaseNotesFiles)" DestinationFolder="$(MSBuildProjectDirectory)\Package" />
65-
<CreateItem Include="$(PackageFiles)">
66-
<Output TaskParameter="Include" ItemName="OutputContent" />
67-
</CreateItem>
68-
<Copy SourceFiles="$(OutputContent)" DestinationFolder="$(MSBuildProjectDirectory)\Package\%(OutputContent.RecursiveDir)" />
67+
68+
<Copy SourceFiles="@(PackageFiles)" DestinationFolder="$(MSBuildProjectDirectory)\Package\%(PackageFiles.RecursiveDir)" />
69+
6970
<CreateItem Include="$(MSBuildProjectDirectory)\Package\**\*.*">
7071
<Output TaskParameter="Include" ItemName="ZipOutputContent" />
7172
</CreateItem>
7273
<Zip Files="@(ZipOutputContent)" WorkingDirectory="$(MSBuildProjectDirectory)\Package" ZipFileName="$(PackageName)_$(Version)_Install.$(Extension)" />
7374
<Copy SourceFiles="$(MSBuildProjectDirectory)\$(PackageName)_$(Version)_Install.$(Extension)" DestinationFolder="$(InstallPath)" />
75+
7476
<Delete Files="$(MSBuildProjectDirectory)\$(PackageName)_$(Version)_Install.$(Extension)" />
7577
<RemoveDir Directories ="$(MSBuildProjectDirectory)\Package" ContinueOnError="WarnAndContinue" />
7678
</Target>

DNN_Platform.sln

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -354,11 +354,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "BuildScripts", "BuildScript
354354
Build\BuildScripts\AEModule.build = Build\BuildScripts\AEModule.build
355355
Build\BuildScripts\AEPackage.targets = Build\BuildScripts\AEPackage.targets
356356
Build\BuildScripts\CombineSymbols.ps1 = Build\BuildScripts\CombineSymbols.ps1
357-
Build\BuildScripts\ICSharpCode.SharpZipLib.dll = Build\BuildScripts\ICSharpCode.SharpZipLib.dll
358-
Build\BuildScripts\DotNetNuke.MSBuild.Tasks.dll = Build\BuildScripts\DotNetNuke.MSBuild.Tasks.dll
359-
Build\BuildScripts\Microsoft.Build.Framework.dll = Build\BuildScripts\Microsoft.Build.Framework.dll
360-
Build\BuildScripts\Microsoft.Build.Utilities.dll = Build\BuildScripts\Microsoft.Build.Utilities.dll
361-
Build\BuildScripts\Microsoft.Build.Utilities.v3.5.dll = Build\BuildScripts\Microsoft.Build.Utilities.v3.5.dll
362357
Build\BuildScripts\Module.build = Build\BuildScripts\Module.build
363358
Build\BuildScripts\ModulePackage.targets = Build\BuildScripts\ModulePackage.targets
364359
Build\BuildScripts\MSBuild.Community.Tasks.dll = Build\BuildScripts\MSBuild.Community.Tasks.dll

0 commit comments

Comments
 (0)