Linter and compiler cleanups and v8 RC5 (#269)

* Remove unused linter flag

* Enable compiler flag and fix docs

* Prepare v8 RC5

Author: NelsonVides

CHANGELOG.md

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## main
 
+## v8.0.0-rc5
+
 - Documentation improvements (#267)
 - Separate edns payload size over UDP as a configurable pipe (#267)
 - Extend pipelines with halt and secondary pipelines (#268)

rebar.config

@@ -12,9 +12,9 @@
     warn_obsolete_guard,
     strict_validation,
     warn_export_vars,
-    warn_exported_vars
+    warn_exported_vars,
+    warn_missing_spec
     % warn_untyped_record
-    % warn_missing_spec,
     % warn_missing_doc
 ]}.
 
@@ -162,8 +162,7 @@
             {elvis_style, state_record_and_type, disable},
             {elvis_style, private_data_types, disable}
         ],
-        ruleset => erl_files_strict,
-        ignore => ['DNS-ASN1']
+        ruleset => erl_files_strict
     },
     #{
         dirs => ["include"],

src/listeners/erldns_proto_udp_acceptor_sup.erl

@@ -1,4 +1,5 @@
 -module(erldns_proto_udp_acceptor_sup).
+-moduledoc false.
 
 -behaviour(supervisor).
 

src/pipes/erldns_axfr.erl

@@ -28,6 +28,7 @@ AXFR zone transfers are not currently implemented. The current "implementation"
 -export([call/2]).
 -export([is_enabled/2]).
 
+-doc "`c:erldns_pipeline:call/2` callback.".
 -spec call(dns:message(), erldns_pipeline:opts()) -> dns:message().
 call(#dns_message{questions = Questions} = Msg, _) ->
     %% If the message is an AXFR request then append the SOA record.
@@ -38,18 +39,17 @@ call(#dns_message{questions = Questions} = Msg, _) ->
             Msg
     end.
 
-%% Determine if AXFR is enabled for the given request host.
+-doc "Determine if AXFR is enabled for the given request host.".
+-spec is_enabled(_, _) -> boolean().
 is_enabled(Host, Metadata) ->
-    MatchingMetadata =
-        lists:filter(
-            fun(MetadataRow) ->
-                [_Id, _DomainId, Kind, Content] = MetadataRow,
-                {ok, AllowedAddress} = inet_parse:address(binary_to_list(Content)),
-                AllowedAddress =:= Host andalso Kind =:= <<"axfr">>
-            end,
-            Metadata
-        ),
-    length(MatchingMetadata) > 0.
+    lists:any(
+        fun(MetadataRow) ->
+            [_Id, _DomainId, Kind, Content] = MetadataRow,
+            {ok, AllowedAddress} = inet_parse:address(binary_to_list(Content)),
+            AllowedAddress =:= Host andalso Kind =:= <<"axfr">>
+        end,
+        Metadata
+    ).
 
 append_soa(Message, []) ->
     Message;