address copilot review feedback

Author: dnywh

e2e/chat.spec.ts

@@ -8,7 +8,6 @@ test("chat loads the seeded thread and composer for a signed-in donor", async ({
     email: DONOR_EMAIL,
     redirectTo: `/chats/${SEEDED_THREAD_ID}`,
   });
-  await page.waitForTimeout(1_000);
 
   await expect(page).toHaveURL(new RegExp(`/chats/${SEEDED_THREAD_ID}$`));
   await expect(page.getByTestId("chat-window")).toBeVisible();

e2e/profile.spec.ts

@@ -6,7 +6,10 @@ test("profile account actions show pending feedback and update the read view", a
 }) => {
   await signIn(page, { email: HOST_EMAIL, redirectTo: "/profile" });
   await delayProfileActionRequests(page);
-  await page.waitForTimeout(3_000);
+
+  const profileAccountSettings = page.getByTestId("profile-account-settings");
+  await expect(profileAccountSettings).toBeVisible();
+  await expect(profileAccountSettings).toHaveAttribute("data-hydrated", "true");
 
   await page.getByTestId("profile-account-first-name-edit").click();
   const firstNameInput = page.getByTestId("profile-account-first-name-input");

src/app/(core)/(interact)/(stretched)/chats/[[...threadId]]/page.tsx

@@ -49,15 +49,6 @@ export default async function ChatsPage({ params }: ChatsPageProps) {
     redirect("/chats");
   }
 
-  const totalUnreadMessages = typedThreads.reduce((count, thread) => {
-    const unreadMessages =
-      thread.chat_messages_with_senders?.filter(
-        (message) => !message.read_at && message.sender_id !== user.id
-      ).length ?? 0;
-
-    return count + unreadMessages;
-  }, 0);
-
   return (
     <ChatPageClient
       user={user}

src/app/(forms)/profile/listings/new/[type]/page.tsx

@@ -1,6 +1,7 @@
 import { createClient } from "@/utils/supabase/server";
 import ListingWrite from "@/components/ListingWrite";
 import FormHeader from "@/components/FormHeader";
+import { redirect } from "next/navigation";
 import type { Metadata } from "next";
 
 type ListingType = "residential" | "community" | "business";
@@ -49,10 +50,14 @@ export default async function NewListingFormContent({
     data: { user },
   } = await supabase.auth.getUser();
 
+  if (!user) {
+    redirect(`/sign-in?redirect_to=/profile/listings/new/${type}`);
+  }
+
   const { data: profile } = await supabase
     .from("profiles")
     .select()
-    .eq("id", user?.id ?? "")
+    .eq("id", user.id)
     .single();
 
   return (

src/components/AvatarUploadManager/AvatarUploadManager.tsx

@@ -5,14 +5,15 @@ import AvatarUploadView from "@/components/AvatarUploadView";
 import { uploadAvatar, deleteAvatar, getAvatarUrl } from "@/utils/mediaUtils";
 import Compressor from "compressorjs";
 import { useTranslations } from "next-intl";
+import type { AvatarBucket } from "@/utils/mediaUtils";
 
 const MAX_MB = 10;
 const MAX_FILE_SIZE = MAX_MB * 1024 * 1024; // 10MB in bytes
 const MAX_DIMENSION = 1024; // Consider going down to 512 for avatars
 
 type AvatarUploadManagerProps = {
   initialAvatar?: string;
-  bucket: string;
+  bucket: AvatarBucket;
   entityId: string;
   onAvatarChange?: (filename: string) => void;
   inputHintShown?: boolean;

src/utils/mediaUtils.ts

@@ -1,7 +1,7 @@
 import { createClient } from "@/utils/supabase/client";
 import { getStoragePublicUrl } from "@/utils/storage";
 
-type AvatarBucket = string;
+export type AvatarBucket = "avatars" | "listing_avatars";
 
 type ListingPhotoRecord = {
   photos: string[] | null;
@@ -37,7 +37,9 @@ export async function uploadAvatar(
       .eq("id", id);
 
     if (updateError) throw updateError;
-  } else {
+  }
+
+  if (bucket === "listing_avatars" && id) {
     const { error: updateError } = await supabase
       .from("listings")
       .update({ avatar: fileName })
@@ -65,7 +67,9 @@ export async function deleteAvatar(
       .eq("id", id);
 
     if (updateError) throw updateError;
-  } else {
+  }
+
+  if (bucket === "listing_avatars" && id) {
     const { error: updateError } = await supabase
       .from("listings")
       .update({ avatar: null })