Skip to content

Commit 4b9e9d4

Browse files
committed
clarify sensitive listing teaser
1 parent 896fbe6 commit 4b9e9d4

4 files changed

Lines changed: 14 additions & 14 deletions

File tree

src/app/(core)/(interact)/(centered)/listings/[slug]/page.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { notFound } from "next/navigation";
33
import {
44
generateListingJsonLd,
55
generateListingMetadata,
6-
getAnonymousResidentialListingTeaser,
6+
getAnonymousSensitiveListingTeaser,
77
getListingDisplayName,
88
} from "@/utils/listingUtils";
99
import { getListingSeoOptions } from "@/utils/listingSeo";
@@ -80,7 +80,7 @@ export default async function ListingPage({
8080

8181
const listingSeoOptions = await getListingSeoOptions();
8282
const listingJsonLd = generateListingJsonLd(listing, user, listingSeoOptions);
83-
const listingForRead = getAnonymousResidentialListingTeaser(listing, user);
83+
const listingForRead = getAnonymousSensitiveListingTeaser(listing, user);
8484
const listingDisplayName = getListingDisplayName(
8585
listingForRead,
8686
user,

src/components/ListingRead/ListingRead.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { Marker, NavigationControl } from "react-map-gl/maplibre";
77
import { createClient } from "@/utils/supabase/client";
88
import { useRouter } from "next/navigation";
99
import {
10-
getAnonymousResidentialListingTeaser,
10+
getAnonymousSensitiveListingTeaser,
1111
getListingDisplayName,
1212
} from "@/utils/listingUtils";
1313
import { parseTextWithLinks } from "@/utils/linkUtils";
@@ -96,7 +96,7 @@ const ListingRead = memo(function Listing({
9696
const rawRealListing =
9797
!isDemo && listing && !isDemoListing(listing) ? (listing as Listing) : null;
9898
const realListing = rawRealListing
99-
? getAnonymousResidentialListingTeaser(rawRealListing, user)
99+
? getAnonymousSensitiveListingTeaser(rawRealListing, user)
100100
: null;
101101
const listingForDisplay = demoListing ?? realListing;
102102

src/utils/listingUtils.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
generateListingDescription,
66
generateListingJsonLd,
77
generateListingMetadata,
8-
getAnonymousResidentialListingTeaser,
8+
getAnonymousSensitiveListingTeaser,
99
getListingAvatar,
1010
} from "./listingUtils.ts";
1111
import type { Listing } from "../types/listing.ts";
@@ -298,7 +298,7 @@ test("anonymous unknown-type metadata emits a private teaser", () => {
298298
includeFullMetadata: true,
299299
});
300300
const description = String(metadata.description);
301-
const teaser = getAnonymousResidentialListingTeaser(unknownTypeListing, null);
301+
const teaser = getAnonymousSensitiveListingTeaser(unknownTypeListing, null);
302302

303303
assert.deepEqual(metadata.title, {
304304
absolute: "Private Host",

src/utils/listingUtils.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ type AvatarDescriptor = {
6666
alt: string;
6767
} | null;
6868

69-
type AnonymousResidentialListingTeaserField =
69+
type AnonymousSensitiveListingTeaserField =
7070
| "name"
7171
| "owner_first_name"
7272
| "owner_avatar"
@@ -78,11 +78,11 @@ type AnonymousResidentialListingTeaserField =
7878
| "links"
7979
| "coordinates";
8080

81-
type AnonymousResidentialListingTeaser<T extends ListingLike> = Omit<
81+
type AnonymousSensitiveListingTeaser<T extends ListingLike> = Omit<
8282
T,
83-
AnonymousResidentialListingTeaserField
83+
AnonymousSensitiveListingTeaserField
8484
> &
85-
Record<AnonymousResidentialListingTeaserField, null>;
85+
Record<AnonymousSensitiveListingTeaserField, null>;
8686

8787
type GenerateListingMetadataOptions = ListingSeoOptions & {
8888
includeFullMetadata?: boolean;
@@ -270,7 +270,7 @@ export function getListingAvatar(
270270
if (listing.is_demo) {
271271
const demoAvatarFilename = listing.avatar?.split("/").pop();
272272
const demoListingDisplayName =
273-
listing.name || listing.owner_first_name || "Listing";
273+
listing.name || listing.owner_first_name || seoCopy.fallbackListingName;
274274

275275
return {
276276
isDemo: true,
@@ -325,10 +325,10 @@ export function getListingOwnerAvatar(
325325
};
326326
}
327327

328-
export function getAnonymousResidentialListingTeaser<T extends ListingLike>(
328+
export function getAnonymousSensitiveListingTeaser<T extends ListingLike>(
329329
listing: T,
330330
user: ListingUser
331-
): T | AnonymousResidentialListingTeaser<T> {
331+
): T | AnonymousSensitiveListingTeaser<T> {
332332
const listingType = normaliseListingType(listing.type);
333333

334334
if (!isSensitiveAnonymousListing(listingType, user)) {
@@ -347,7 +347,7 @@ export function getAnonymousResidentialListingTeaser<T extends ListingLike>(
347347
photos: null,
348348
links: null,
349349
coordinates: null,
350-
} as AnonymousResidentialListingTeaser<T>;
350+
} as AnonymousSensitiveListingTeaser<T>;
351351
}
352352

353353
export function getProfileAvatarSource(

0 commit comments

Comments
 (0)