address chat and media review feedback

Author: dnywh

supabase/functions/_shared/storage-utils.ts

@@ -24,16 +24,8 @@ export async function deleteStorageObject(
 
 export async function deleteListingMedia(
   supabase: SupabaseClient,
-  slug: string
+  listing: ListingMedia | null
 ) {
-  // Service-role callers use this after authorising the requested listing operation.
-  const { data: listing, error: fetchError } = await supabase
-    .from("listings")
-    .select("avatar, photos")
-    .eq("slug", slug)
-    .maybeSingle<ListingMedia>();
-
-  if (fetchError) throw fetchError;
   if (!listing) return;
 
   const deletePromises = [];

supabase/functions/delete-account/index.ts

@@ -72,7 +72,7 @@ serve(async (req) => {
     // Fetch all listings for the user to delete their avatars
     const { data: listings, error: listingsError } = await supabaseAdmin
       .from("listings")
-      .select("slug")
+      .select("slug, avatar, photos")
       .eq("owner_id", user.id);
     if (listingsError) {
       console.error("Listings fetch error:", listingsError);
@@ -86,7 +86,7 @@ serve(async (req) => {
       }
 
       try {
-        await deleteListingMedia(supabaseAdmin, listing.slug);
+        await deleteListingMedia(supabaseAdmin, listing);
       } catch (error) {
         console.error(
           `Error deleting media for listing ${listing.slug}:`,

supabase/functions/delete-listing/index.ts

@@ -61,7 +61,7 @@ serve(async (req) => {
 
     const { data: listing, error: listingError } = await supabaseAdmin
       .from("listings")
-      .select("id, owner_id")
+      .select("id, owner_id, avatar, photos")
       .eq("slug", slug)
       .maybeSingle();
 
@@ -72,7 +72,7 @@ serve(async (req) => {
     }
 
     // Delete all media first
-    await deleteListingMedia(supabaseAdmin, slug);
+    await deleteListingMedia(supabaseAdmin, listing);
 
     // Delete the listing
     const { data: deletedListing, error: deleteError } = await supabaseAdmin

supabase/functions/send-email-for-new-chat-message/index.ts

@@ -152,8 +152,8 @@ const handler = async (_request: Request): Promise<Response> => {
       throw new Error(`No recipient found for message ${record.id}`);
     }
 
-    // Determine recipient's role in the chat (listing owner (host) or the thread initiator (donor)?)
-    // This ternary seems opposite to what's logical, but it is correct somehow
+    // recipientRole is the role of the email recipient, not the sender.
+    // If the owner sent the message, the recipient is the initiator; otherwise the recipient is the owner.
     const recipientRole =
       threadData.owner_id === messageData.sender_id ? "initiator" : "owner";
 

supabase/migrations/20260511082333_add_chat_thread_initiator_rate_limit_index.sql

@@ -0,0 +1,5 @@
+-- Match the thread-start rate-limit predicate:
+-- initiator_id = <user> and created_at >= now() - interval '1 hour'.
+
+create index if not exists chat_threads_initiator_id_created_at_idx
+  on public.chat_threads (initiator_id, created_at desc);