address review on local media seeding

Author: dnywh

docs/supabase-local-first.md

@@ -34,7 +34,7 @@ What this does:
 - A PR branch that changes `supabase/**` gets its own Supabase preview branch.
 - That preview branch runs migrations and bucket config from Git.
 - Seed data comes from `supabase/seed.sql`, not from production data.
-- Local demo bucket objects come from `supabase/storage/`, not from production storage.
+- Demo media is tracked under `supabase/storage/`, but is uploaded only into local Supabase with `npm run seed:local-media`.
 
 ### 2. Require the Supabase PR Check in GitHub
 

scripts/seed-local-media.mjs

@@ -99,27 +99,39 @@ function normalizeFileSizeLimit(fileSizeLimit) {
 }
 
 async function ensureBucket(supabase, bucketName, bucketConfig) {
-  const { error } = await supabase.storage.createBucket(bucketName, {
+  const normalizedConfig = {
     public: bucketConfig.public,
     fileSizeLimit: normalizeFileSizeLimit(bucketConfig.fileSizeLimit),
     allowedMimeTypes: bucketConfig.allowedMimeTypes,
-  });
+  };
+
+  const { data: buckets, error: listError } = await supabase.storage.listBuckets();
+
+  if (listError) {
+    throw listError;
+  }
 
-  if (!error) return;
+  const existingBucket = buckets?.find(
+    (bucket) => bucket.id === bucketName || bucket.name === bucketName
+  );
 
-  const message = error.message?.toLowerCase() ?? "";
-  const alreadyExists =
-    message.includes("already exists") || message.includes("duplicate");
+  if (!existingBucket) {
+    const { error: createError } = await supabase.storage.createBucket(
+      bucketName,
+      normalizedConfig
+    );
 
-  if (!alreadyExists) {
-    throw error;
+    if (createError) {
+      throw createError;
+    }
+
+    return;
   }
 
-  const { error: updateError } = await supabase.storage.updateBucket(bucketName, {
-    public: bucketConfig.public,
-    fileSizeLimit: normalizeFileSizeLimit(bucketConfig.fileSizeLimit),
-    allowedMimeTypes: bucketConfig.allowedMimeTypes,
-  });
+  const { error: updateError } = await supabase.storage.updateBucket(
+    bucketName,
+    normalizedConfig
+  );
 
   if (updateError) {
     throw updateError;