Skip to content

Commit a0ce1ba

Browse files
committed
address copilot review
1 parent 26fd44e commit a0ce1ba

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

.github/workflows/validate-app.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,6 @@ jobs:
7878
- name: Seed local demo media
7979
run: npm run seed:local-media
8080

81-
- name: Build app for production-mode smoke test
82-
run: npm run build
83-
8481
- name: Install Playwright browser
8582
run: npx playwright install --with-deps chromium
8683

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"i18n:check": "node scripts/check-i18n-messages.mjs",
1616
"check": "npm run i18n:check && npm run format:check",
1717
"test:e2e": "playwright test",
18+
"pretest:e2e:prod": "npm run build",
1819
"test:e2e:prod": "playwright test --config=playwright.prod.config.ts",
1920
"test:e2e:debug": "playwright test --headed --workers=1",
2021
"format": "prettier --write .",

playwright.config.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ export default defineConfig({
1212
baseURL,
1313
headless: true,
1414
locale: "en-AU",
15-
launchOptions: {
16-
chromiumSandbox: process.platform === "darwin",
17-
},
15+
launchOptions:
16+
process.platform === "darwin" ? { chromiumSandbox: true } : undefined,
1817
extraHTTPHeaders: {
1918
"Accept-Language": "en-AU,en;q=0.9",
2019
},

playwright.prod.config.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ export default defineConfig({
1212
baseURL,
1313
headless: true,
1414
locale: "en-AU",
15+
launchOptions:
16+
process.platform === "darwin" ? { chromiumSandbox: true } : undefined,
1517
extraHTTPHeaders: {
1618
"Accept-Language": "en-AU,en;q=0.9",
1719
},

0 commit comments

Comments
 (0)