fix residential seo copy fallbacks

Author: dnywh

messages/de.json

@@ -430,7 +430,8 @@
       "localCommunity": "Lokale Gemeinschaft",
       "businessIn": "Unternehmen in {area}",
       "localBusiness": "Lokales Unternehmen",
-      "avatarAlt": "Der Avatar für diesen Eintrag"
+      "avatarAlt": "Der Avatar für diesen Eintrag",
+      "privateHostAvatarAlt": "Ein verschwommener Avatar für {name}. Melde dich an, um die vollständigen Informationen zu sehen."
     },
     "seo": {
       "privateHostName": "Privater Host",

messages/en.json

@@ -430,7 +430,8 @@
       "localCommunity": "Local community",
       "businessIn": "Business in {area}",
       "localBusiness": "Local business",
-      "avatarAlt": "The avatar for this listing"
+      "avatarAlt": "The avatar for this listing",
+      "privateHostAvatarAlt": "A blurred avatar for {name}. Sign in to see their full information."
     },
     "seo": {
       "privateHostName": "Private Host",

messages/es.json

@@ -430,7 +430,8 @@
       "localCommunity": "Comunidad local",
       "businessIn": "Negocio en {area}",
       "localBusiness": "Negocio local",
-      "avatarAlt": "El avatar de este anuncio"
+      "avatarAlt": "El avatar de este anuncio",
+      "privateHostAvatarAlt": "Un avatar difuminado de {name}. Inicia sesión para ver la información completa."
     },
     "seo": {
       "privateHostName": "Anfitrión privado",

messages/fr.json

@@ -430,7 +430,8 @@
       "localCommunity": "Communauté locale",
       "businessIn": "Commerce à {area}",
       "localBusiness": "Commerce local",
-      "avatarAlt": "L’avatar de cette annonce"
+      "avatarAlt": "L’avatar de cette annonce",
+      "privateHostAvatarAlt": "Un avatar flouté pour {name}. Connectez-vous pour voir les informations complètes."
     },
     "seo": {
       "privateHostName": "Hôte privé",

messages/pt-BR.json

@@ -430,7 +430,8 @@
       "localCommunity": "Comunidade local",
       "businessIn": "Negócio em {area}",
       "localBusiness": "Negócio local",
-      "avatarAlt": "O avatar deste anúncio"
+      "avatarAlt": "O avatar deste anúncio",
+      "privateHostAvatarAlt": "Um avatar desfocado de {name}. Entre para ver as informações completas."
     },
     "seo": {
       "privateHostName": "Anfitrião privado",

src/components/ListingHeader/ListingHeader.tsx

@@ -130,7 +130,14 @@ function ListingHeader({
   user?: any;
 }) {
   const t = useTranslations();
-  const avatarProps = getListingAvatar(listing, user);
+  const privateHostName = t("Listings.seo.privateHostName");
+  const avatarProps = getListingAvatar(listing, user, {
+    privateHostName,
+    fallbackListingName: t("Listings.seo.fallbackListingName"),
+    privateHostAvatarAlt: t("Listings.read.privateHostAvatarAlt", {
+      name: privateHostName,
+    }),
+  });
 
   return (
     <StyledListingHeader $presentation={presentation}>

src/utils/listingUtils.test.ts

@@ -6,6 +6,7 @@ import {
   generateListingJsonLd,
   generateListingMetadata,
   getAnonymousResidentialListingTeaser,
+  getListingAvatar,
 } from "./listingUtils.ts";
 import type { Listing } from "../types/listing.ts";
 import type { ListingSeoCopy } from "./listingUtils.ts";
@@ -308,9 +309,37 @@ test("authenticated residential metadata can use private display names", () => {
   assert.deepEqual(metadata.title, {
     absolute: "Sam",
   });
+  assert.match(
+    String(metadata.description),
+    /^Sam accepts food scraps for composting in Marrickville, Australia\./
+  );
+  assert.doesNotMatch(String(metadata.description), /helps people compost/);
   assert.equal(metadata.robots, undefined);
 });
 
+test("anonymous residential avatars can use localised private-host alt text", () => {
+  const residentialListing = {
+    ...communityListing,
+    type: "residential",
+    name: "Sam's backyard bin",
+    owner_first_name: "Sam",
+    slug: "private-host",
+  } satisfies Listing;
+
+  const avatar = getListingAvatar(residentialListing, null, {
+    privateHostName: "Anfitrión privado",
+    fallbackListingName: "Anuncio",
+    privateHostAvatarAlt:
+      "Un avatar difuminado de Anfitrión privado. Inicia sesión para ver la información completa.",
+  });
+
+  assert.equal(
+    avatar?.alt,
+    "Un avatar difuminado de Anfitrión privado. Inicia sesión para ver la información completa."
+  );
+  assert.doesNotMatch(avatar?.alt ?? "", /Private Host/);
+});
+
 test("listing JSON-LD describes the public listing page and place conservatively", () => {
   const jsonLd = generateListingJsonLd(communityListing, null);
 

src/utils/listingUtils.ts

@@ -49,7 +49,9 @@ export type ListingSeoCopy = {
 type ListingDisplayNameCopy = Pick<
   ListingSeoCopy,
   "privateHostName" | "fallbackListingName"
->;
+> & {
+  privateHostAvatarAlt?: string;
+};
 
 type ListingSeoOptions = {
   locale?: string;
@@ -258,7 +260,8 @@ export function getListingDisplayName(
 
 export function getListingAvatar(
   listing: ListingLike | null | undefined,
-  user: ListingUser
+  user: ListingUser,
+  seoCopy: ListingDisplayNameCopy = defaultListingSeoCopy
 ): AvatarDescriptor {
   if (!listing) return null;
 
@@ -276,21 +279,23 @@ export function getListingAvatar(
     };
   }
 
-  const listingDisplayName = getListingDisplayName(listing, user);
+  const listingDisplayName = getListingDisplayName(listing, user, seoCopy);
 
   if (isSensitiveAnonymousListing(listingType, user)) {
     return {
       bucket: "public",
       filename: "avatars/default/private.jpg",
-      alt: "A blurred avatar for Private Host. Sign in to see their full information.",
+      alt:
+        seoCopy.privateHostAvatarAlt ??
+        `A blurred avatar for ${seoCopy.privateHostName}. Sign in to see their full information.`,
     };
   }
 
   if (listingType === "residential") {
     return {
       bucket: "avatars",
       filename: listing.owner_avatar || null,
-      alt: `${listing.owner_first_name || "Private Host"} avatar`,
+      alt: `${listing.owner_first_name || seoCopy.privateHostName} avatar`,
     };
   }
 
@@ -388,8 +393,12 @@ export function generateListingDescription(
   const listingDisplayName = getListingDisplayName(listing, user, seoCopy);
   const listingType = normaliseListingType(listing.type);
   const isSensitiveAnonymous = isSensitiveAnonymousListing(listingType, user);
+  const shouldUseResidentialIntro =
+    listingType === "residential" || isSensitiveAnonymous;
+  const shouldOmitListingDescription =
+    listingType === "residential" || isSensitiveAnonymous;
   const listingFullLocation = getListingLocation(listing, options.locale);
-  const listingIntro = isSensitiveAnonymous
+  const listingIntro = shouldUseResidentialIntro
     ? seoCopy.residentialIntro({
         name: listingDisplayName,
         location: listingFullLocation || undefined,
@@ -403,7 +412,7 @@ export function generateListingDescription(
     : listing.name || listingDisplayName;
   const listingDescriptionParts = [
     listingIntro,
-    isSensitiveAnonymous
+    shouldOmitListingDescription
       ? null
       : listing.description?.trim()
         ? listing.description.trim()