Add magic numbers to environment

Author: dobro10k2

brain_games/games/calc.py

@@ -1,12 +1,16 @@
 import random
 
+MIN_NUMBER = 1
+MAX_NUMBER = 20
+OPERATIONS = ["+", "-", "*"]
+
 TASK = "What is the result of the expression?"
 
 
 def get_round():
-    num1 = random.randint(1, 20)
-    num2 = random.randint(1, 20)
-    op = random.choice(["+", "-", "*"])
+    num1 = random.randint(MIN_NUMBER, MAX_NUMBER)
+    num2 = random.randint(MIN_NUMBER, MAX_NUMBER)
+    op = random.choice(OPERATIONS)
 
     match op:
         case "+":

brain_games/games/even.py

@@ -1,5 +1,8 @@
 import random
 
+MIN_NUMBER = 1
+MAX_NUMBER = 100
+
 TASK = 'Answer "yes" if the number is even, otherwise answer "no".'
 
 
@@ -8,7 +11,7 @@ def is_even(number: int) -> bool:
 
 
 def get_round():
-    number = random.randint(1, 100)
+    number = random.randint(MIN_NUMBER, MAX_NUMBER)
     question = str(number)
     correct_answer = "yes" if is_even(number) else "no"
     return question, correct_answer

brain_games/games/gcd.py

@@ -1,12 +1,15 @@
 import math
 import random
 
+MIN_NUMBER = 1
+MAX_NUMBER = 100
+
 TASK = "Find the greatest common divisor of given numbers."
 
 
 def get_round():
-    num1 = random.randint(1, 100)
-    num2 = random.randint(1, 100)
+    num1 = random.randint(MIN_NUMBER, MAX_NUMBER)
+    num2 = random.randint(MIN_NUMBER, MAX_NUMBER)
 
     question = f"{num1} {num2}"
     correct_answer = str(math.gcd(num1, num2))

brain_games/games/prime.py

@@ -1,5 +1,8 @@
 import random
 
+MIN_NUMBER = 1
+MAX_NUMBER = 100
+
 TASK = 'Answer "yes" if given number is prime. Otherwise answer "no".'
 
 
@@ -17,7 +20,7 @@ def is_prime(n: int) -> bool:
 
 
 def get_round():
-    number = random.randint(1, 100)
+    number = random.randint(MIN_NUMBER, MAX_NUMBER)
     question = str(number)
     correct_answer = "yes" if is_prime(number) else "no"
     return question, correct_answer

brain_games/games/progression.py

@@ -1,5 +1,13 @@
 import random
 
+MIN_LENGTH = 5
+MAX_LENGTH = 10
+MIN_START = 1
+MAX_START = 20
+MIN_STEP = 1
+MAX_STEP = 10
+HIDDEN_PLACEHOLDER = ".."
+
 TASK = "What number is missing in the progression?"
 
 
@@ -8,15 +16,15 @@ def make_progression(start, step, length):
 
 
 def get_round():
-    length = random.randint(5, 10)  # длина от 5 до 10 включительно
-    start = random.randint(1, 20)
-    step = random.randint(1, 10)
+    length = random.randint(MIN_LENGTH, MAX_LENGTH)
+    start = random.randint(MIN_START, MAX_START)
+    step = random.randint(MIN_STEP, MAX_STEP)
 
     progression = make_progression(start, step, length)
     hidden_index = random.randint(0, length - 1)
 
     correct_answer = str(progression[hidden_index])
-    progression[hidden_index] = ".."
+    progression[hidden_index] = HIDDEN_PLACEHOLDER
     question = " ".join(map(str, progression))
 
     return question, correct_answer

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "hexlet-code"
-version = "0.8.0"
+version = "0.9.0"
 description = "«Игры разума» — набор из пяти консольных игр"
 readme = "README.md"
 authors = [