Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Substitute parameters before validation #811

Open
@eliaskoromilas

Description

Description

docker app build/validate does not involve parameter substitution -> false negatives

Steps to reproduce the issue:

  1. docker-compose.yml
version: '3.2'
services:
  hello-world:
    image: hello-world
    volumes:
    - ${test}:/path/to/bar
  1. parameters.yml
test: /path/to/foo
  1. docker app build . / docker app validate

Describe the results you received:

Compose file validation failed:
* can't use relative path as volume source ("${test}:/path/to/bar") in service "hello-world"

Describe the results you expected:

Validated "hello-world.dockerapp"

Output of docker version:

Docker version 20.10.5, build 55c4c88

Output of docker app version:

Version:               v0.9.1-beta3
Git commit:            9d2c67f8
OS/Arch:               linux/amd64

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions