build: toControllerOptions: micro-optimization

thaJeztah · thaJeztah · commit 8ec437d2a612 · 2023-06-23T12:36:37.000+02:00
Swapping the order of these checks, which I guess is the most minimal
optimization possible

    BenchmarkGetEnv-10    68764720    16.82  ns/op   0 B/op   0 allocs/op
    BenchmarkMap-10      454135184     2.635 ns/op   0 B/op   0 allocs/op

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/commands/build.go b/commands/build.go
@@ -121,8 +121,8 @@ func (o *buildOptions) toControllerOptions() (*controllerapi.BuildOptions, error
 	}
 
 	// TODO: extract env var parsing to a method easily usable by library consumers
-	if v := os.Getenv("SOURCE_DATE_EPOCH"); v != "" {
-		if _, ok := opts.BuildArgs["SOURCE_DATE_EPOCH"]; !ok {
+	if _, ok := opts.BuildArgs["SOURCE_DATE_EPOCH"]; !ok {
+		if v := os.Getenv("SOURCE_DATE_EPOCH"); v != "" {
 			opts.BuildArgs["SOURCE_DATE_EPOCH"] = v
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -121,8 +121,8 @@ func (o buildOptions) toControllerOptions() (controllerapi.BuildOptions, error`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`// TODO: extract env var parsing to a method easily usable by library consumers`
`124`		`- if v := os.Getenv("SOURCE_DATE_EPOCH"); v != "" {`
`125`		`- if _, ok := opts.BuildArgs["SOURCE_DATE_EPOCH"]; !ok {`
	`124`	`+ if _, ok := opts.BuildArgs["SOURCE_DATE_EPOCH"]; !ok {`
	`125`	`+ if v := os.Getenv("SOURCE_DATE_EPOCH"); v != "" {`
`126`	`126`	`opts.BuildArgs["SOURCE_DATE_EPOCH"] = v`
`127`	`127`	`}`
`128`	`128`	`}`