Pass empty kubeconfig path when loading default Kubernetes configuration #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in-cluster configuration could not be used because the ExplicitPath was always set in the `ClientConfigLoadingRules`. If `ExplicitPath` is not set, `ClientConfigLoadingRules` will look up all of the standard environment variables to find the kubeconfig file, including supporting in cluster authentication. We leave the `kubeconfig` parameter on `FromKubeConfig` to support explicitly setting the path and also to not change the signature. This will fix docker/buildx#256 once the docker/cli dependency is updated. Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
|
Ping @mat007 do we want this PR for the next 20.0X release? If so we need to be sure it won't break desktop. |
|
PTAL @tonistiigi @thaJeztah Seems needed for docker/buildx#256 |
hc0503
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in-cluster configuration could not be used because the
ExplicitPath was always set in the
ClientConfigLoadingRules.If
ExplicitPathis not set,ClientConfigLoadingRuleswill look upall of the standard environment variables to find the kubeconfig file,
including supporting in cluster authentication.
We leave the
kubeconfigparameter onFromKubeConfigto supportexplicitly setting the path and also to not change the signature.
This will fix docker/buildx#256 once the docker/cli dependency is
updated.
Signed-off-by: [email protected] [email protected]
- Description for the changelog
Added support for in-cluster Kubernetes authentication for Kubernetes contexts.