Remove the markdown renderer from the factory

rumpl · rumpl · commit ac2a7061a3e2 · 2025-11-23T00:24:41.000+01:00
None of the tool components need this any more

Signed-off-by: Djordje Lukic &lt;djordje.lukic@docker.com&gt;
diff --git a/pkg/tui/components/tool/defaulttool/defaulttool.go b/pkg/tui/components/tool/defaulttool/defaulttool.go
@@ -2,7 +2,6 @@ package defaulttool
 
 import (
 	tea "charm.land/bubbletea/v2"
-	"github.com/charmbracelet/glamour/v2"
 
 	"github.com/docker/cagent/pkg/tui/components/spinner"
 	"github.com/docker/cagent/pkg/tui/components/toolcommon"
@@ -25,7 +24,6 @@ type Component struct {
 // New creates a new default tool component.
 func New(
 	msg *types.Message,
-	_ *glamour.TermRenderer,
 	_ *service.SessionState,
 ) layout.Model {
 	return &Component{
diff --git a/pkg/tui/components/tool/editfile/editfile.go b/pkg/tui/components/tool/editfile/editfile.go
@@ -5,7 +5,6 @@ import (
 	"fmt"
 
 	tea "charm.land/bubbletea/v2"
-	"github.com/charmbracelet/glamour/v2"
 
 	"github.com/docker/cagent/pkg/tools/builtin"
 	"github.com/docker/cagent/pkg/tui/components/spinner"
@@ -29,7 +28,6 @@ type Component struct {
 
 func New(
 	msg *types.Message,
-	_ *glamour.TermRenderer,
 	sessionState *service.SessionState,
 ) layout.Model {
 	return &Component{
diff --git a/pkg/tui/components/tool/factory.go b/pkg/tui/components/tool/factory.go
@@ -37,10 +37,10 @@ func (f *Factory) Create(
 	toolName := msg.ToolCall.Function.Name
 
 	if builder, ok := f.registry.Get(toolName); ok {
-		return builder(msg, renderer, sessionState)
+		return builder(msg, sessionState)
 	}
 
-	return defaulttool.New(msg, renderer, sessionState)
+	return defaulttool.New(msg, sessionState)
 }
 
 var (
diff --git a/pkg/tui/components/tool/readfile/readfile.go b/pkg/tui/components/tool/readfile/readfile.go
@@ -4,7 +4,6 @@ import (
 	"encoding/json"
 
 	tea "charm.land/bubbletea/v2"
-	"github.com/charmbracelet/glamour/v2"
 
 	"github.com/docker/cagent/pkg/tools/builtin"
 	"github.com/docker/cagent/pkg/tui/components/spinner"
@@ -26,7 +25,6 @@ type Component struct {
 // New creates a new read file component.
 func New(
 	msg *types.Message,
-	_ *glamour.TermRenderer,
 	_ *service.SessionState,
 ) layout.Model {
 	return &Component{
diff --git a/pkg/tui/components/tool/registry.go b/pkg/tui/components/tool/registry.go
@@ -3,8 +3,6 @@ package tool
 import (
 	"sync"
 
-	"github.com/charmbracelet/glamour/v2"
-
 	"github.com/docker/cagent/pkg/tui/core/layout"
 	"github.com/docker/cagent/pkg/tui/service"
 	"github.com/docker/cagent/pkg/tui/types"
@@ -13,7 +11,6 @@ import (
 // ComponentBuilder is a function that creates a tool component.
 type ComponentBuilder func(
 	msg *types.Message,
-	renderer *glamour.TermRenderer,
 	sessionState *service.SessionState,
 ) layout.Model
 
diff --git a/pkg/tui/components/tool/shell/shell.go b/pkg/tui/components/tool/shell/shell.go
@@ -4,7 +4,6 @@ import (
 	"encoding/json"
 
 	tea "charm.land/bubbletea/v2"
-	"github.com/charmbracelet/glamour/v2"
 
 	"github.com/docker/cagent/pkg/tools/builtin"
 	"github.com/docker/cagent/pkg/tui/components/spinner"
@@ -24,7 +23,6 @@ type Component struct {
 
 func New(
 	msg *types.Message,
-	_ *glamour.TermRenderer,
 	_ *service.SessionState,
 ) layout.Model {
 	return &Component{
diff --git a/pkg/tui/components/tool/todotool/component.go b/pkg/tui/components/tool/todotool/component.go
@@ -5,7 +5,6 @@ import (
 	"strings"
 
 	tea "charm.land/bubbletea/v2"
-	"github.com/charmbracelet/glamour/v2"
 
 	"github.com/docker/cagent/pkg/tools/builtin"
 	"github.com/docker/cagent/pkg/tui/components/spinner"
@@ -29,7 +28,6 @@ type Component struct {
 // This component handles create, create_multiple, list, and update operations.
 func New(
 	msg *types.Message,
-	renderer *glamour.TermRenderer,
 	_ *service.SessionState,
 ) layout.Model {
 	return &Component{
diff --git a/pkg/tui/components/tool/transfertask/transfertask.go b/pkg/tui/components/tool/transfertask/transfertask.go
@@ -4,7 +4,6 @@ import (
 	"encoding/json"
 
 	tea "charm.land/bubbletea/v2"
-	"github.com/charmbracelet/glamour/v2"
 
 	"github.com/docker/cagent/pkg/tools/builtin"
 	"github.com/docker/cagent/pkg/tui/core/layout"
@@ -20,7 +19,6 @@ type Component struct {
 
 func New(
 	msg *types.Message,
-	_ *glamour.TermRenderer,
 	_ *service.SessionState,
 ) layout.Model {
 	return &Component{
diff --git a/pkg/tui/components/tool/writefile/writefile.go b/pkg/tui/components/tool/writefile/writefile.go
@@ -4,7 +4,6 @@ import (
 	"encoding/json"
 
 	tea "charm.land/bubbletea/v2"
-	"github.com/charmbracelet/glamour/v2"
 
 	"github.com/docker/cagent/pkg/tools/builtin"
 	"github.com/docker/cagent/pkg/tui/components/spinner"
@@ -25,7 +24,6 @@ type Component struct {
 
 func New(
 	msg *types.Message,
-	_ *glamour.TermRenderer,
 	_ *service.SessionState,
 ) layout.Model {
 	return &Component{

Original file line number	Diff line number	Diff line change
`@@ -37,10 +37,10 @@ func (f *Factory) Create(`
`37`	`37`	`toolName := msg.ToolCall.Function.Name`
`38`	`38`
`39`	`39`	`if builder, ok := f.registry.Get(toolName); ok {`
`40`		`- return builder(msg, renderer, sessionState)`
	`40`	`+ return builder(msg, sessionState)`
`41`	`41`	`}`
`42`	`42`
`43`		`- return defaulttool.New(msg, renderer, sessionState)`
	`43`	`+ return defaulttool.New(msg, sessionState)`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`var (`