Skip to content

Commit 2b1c091

Browse files
committed
remove "//go:build go1.26" workarounds
These were added because the repository was not a module: consumers got an implicitly generated go.mod, which made go assume the "go1.16" language version and reject any newer language feature. The "//go:build" directive overrode the language version on a per-file basis. Now that there is a real go.mod, its "go" directive sets the language version for every file in the module, so the workaround can go, as the FIXME they carried asked for. Assisted-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
1 parent dc6330c commit 2b1c091

139 files changed

Lines changed: 0 additions & 417 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

cli-plugins/hooks/hook_types.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
2-
//go:build go1.26
3-
41
// Package hooks defines the contract between the Docker CLI and CLI plugin hook
52
// implementations.
63
//

cli-plugins/hooks/template.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
2-
//go:build go1.26
3-
41
package hooks
52

63
import (

cli-plugins/manager/error.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
2-
//go:build go1.26
3-
41
package manager
52

63
import (

cli-plugins/manager/hooks.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
2-
//go:build go1.26
3-
41
package manager
52

63
import (

cli-plugins/manager/manager.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
2-
//go:build go1.26
3-
41
package manager
52

63
import (

cli-plugins/manager/plugin.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
2-
//go:build go1.26
3-
41
package manager
52

63
import (

cli-plugins/plugin/plugin.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
2-
//go:build go1.26
3-
41
package plugin
52

63
import (

cli/cobra.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
2-
//go:build go1.26
3-
41
package cli
52

63
import (

cli/command/cli.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
2-
//go:build go1.26
3-
41
package command
52

63
import (

cli/command/config/formatter.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
// FIXME(thaJeztah): remove once we are a module; the go:build directive prevents go from downgrading language version to go1.16:
2-
//go:build go1.26
3-
41
package config
52

63
import (

0 commit comments

Comments
 (0)