Apply suggestions from code review

mattmacleod · vvoland · web-flow · commit 2b2b09f82d0c · 2024-11-28T15:21:23.000Z
Simplify test assertion

Co-authored-by: Paweł Gronowski &lt;me@woland.xyz&gt;
diff --git a/cli/connhelper/connhelper_test.go b/cli/connhelper/connhelper_test.go
@@ -86,9 +86,7 @@ func TestDockerSSHBinaryOverride(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Setenv(DockerSSHRemoteBinaryEnv, tc.env)
 			result := dockerSSHRemoteBinary()
-			if result != tc.expected {
-				t.Errorf("expected %q, got %q", tc.expected, result)
-			}
+			assert.Check(t, is.Equal(result, tc.expected))
 		})
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -86,9 +86,7 @@ func TestDockerSSHBinaryOverride(t *testing.T) {`
`86`	`86`	`t.Run(tc.name, func(t *testing.T) {`
`87`	`87`	`t.Setenv(DockerSSHRemoteBinaryEnv, tc.env)`
`88`	`88`	`result := dockerSSHRemoteBinary()`
`89`		`- if result != tc.expected {`
`90`		`- t.Errorf("expected %q, got %q", tc.expected, result)`
`91`		`- }`
	`89`	`+ assert.Check(t, is.Equal(result, tc.expected))`
`92`	`90`	`})`
`93`	`91`	`}`
`94`	`92`	`}`