fix: move recording proxy cleanup defer out of if/else block

The defer for recordCleanup was inside an else block, which meant it
was scoped to that block only. Restructure to declare variables first,
check the error, then defer cleanup unconditionally - matching the
pattern already used in run.go.

Fixes #1980
Fixes #1987

Assisted-By: docker-agent

Author: dgageot

cmd/root/api.go

@@ -71,15 +71,15 @@ func (f *apiFlags) runAPICommand(cmd *cobra.Command, args []string) error {
 	}()
 
 	// Start recording proxy if --record is specified
-	if _, recordCleanup, err := setupRecordingProxy(f.recordPath, &f.runConfig); err != nil {
+	_, recordCleanup, err := setupRecordingProxy(f.recordPath, &f.runConfig)
+	if err != nil {
 		return err
-	} else {
-		defer func() {
-			if err := recordCleanup(); err != nil {
-				slog.Error("Failed to cleanup recording proxy", "error", err)
-			}
-		}()
 	}
+	defer func() {
+		if err := recordCleanup(); err != nil {
+			slog.Error("Failed to cleanup recording proxy", "error", err)
+		}
+	}()
 
 	if f.pullIntervalMins > 0 && !config.IsOCIReference(agentsPath) {
 		return fmt.Errorf("--pull-interval flag can only be used with OCI references, not local files")