Skip to content

Commit be64f3b

Browse files
committed
eval: pre-populate criterion names in CheckRelevance results
When a criterion check errors (context cancelled, judge API failure), the continue left results[i] as a zero-value RelevanceResult with empty Criterion. Pre-populate criterion names before the loop so every entry is well-formed regardless of errors. Addresses review feedback from #2309. Assisted-By: docker-agent
1 parent 15d0327 commit be64f3b

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

pkg/evaluation/judge.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,16 +149,16 @@ func (j *Judge) CheckRelevance(ctx context.Context, response string, criteria []
149149
// caller can fail fast on judge misconfiguration.
150150
var errs []error
151151
results = make([]RelevanceResult, len(criteria))
152+
for i := range results {
153+
results[i].Criterion = criteria[i]
154+
}
152155
for i, r := range rawResults {
153156
if r.err != nil {
154157
errs = append(errs, fmt.Errorf("checking %q: %w", criteria[i], r.err))
155158
continue
156159
}
157-
results[i] = RelevanceResult{
158-
Criterion: criteria[i],
159-
Passed: r.passed,
160-
Reason: r.reason,
161-
}
160+
results[i].Passed = r.passed
161+
results[i].Reason = r.reason
162162
}
163163

164164
if len(errs) > 0 {

0 commit comments

Comments
 (0)