fix logger

Author: lucadruda

src/index.ts

@@ -28,7 +28,7 @@ import { Asset } from './asset';
 import { Repos } from './repos';
 import { Accounts } from './accounts';
 import { Search } from './search';
-import { logger } from './logger';
+import { initLogger, logger } from './logger';
 
 const DEFAULT_PORT = 3000;
 const STDIO_OPTION = 'stdio';
@@ -175,7 +175,7 @@ function parseTransportFlag(args: string[]): string {
     return transportArg;
 }
 
-function parsUsernameFlag(args: string[]): string | undefined {
+function parseUsernameFlag(args: string[]): string | undefined {
     const usernameArg = args.find((arg) => arg.startsWith('--username='))?.split('=')[1];
     if (!usernameArg) {
         logger.info('username unspecified');
@@ -185,6 +185,16 @@ function parsUsernameFlag(args: string[]): string | undefined {
     return usernameArg;
 }
 
+function parseLogsDir(args: string[]): string | undefined {
+    const logsDirArg = args.find((arg) => arg.startsWith('--logs-dir='))?.split('=')[1];
+    if (!logsDirArg) {
+        console.warn('logs dir unspecified');
+        return undefined;
+    }
+
+    return logsDirArg;
+}
+
 function parsePortFlag(args: string[]): number {
     const portArg = args.find((arg) => arg.startsWith('--port='))?.split('=')[1];
     if (!portArg || portArg.length === 0) {
@@ -204,10 +214,12 @@ function parsePortFlag(args: string[]): number {
 // Main execution
 async function main() {
     const args = process.argv.slice(2);
+    const logsDir = parseLogsDir(args);
+    initLogger(logsDir);
     logger.info(args.length > 0 ? `provided arguments: ${args}` : 'no arguments provided');
     const transportArg = parseTransportFlag(args);
     const port = parsePortFlag(args);
-    const username = parsUsernameFlag(args);
+    const username = parseUsernameFlag(args);
     const patToken = process.env.HUB_PAT_TOKEN;
 
     const server = new HubMCPServer(username, patToken);

src/logger.ts

@@ -14,46 +14,46 @@
    limitations under the License.
 */
 
+import path from 'path';
 import winston, { format } from 'winston';
+export let logger: winston.Logger;
 
-export const logger = winston.createLogger({
-    level: 'info',
-    format: format.combine(
-        format.timestamp({
-            format: 'YYYY-MM-DD HH:mm:ss',
-        }),
-        format.errors({ stack: true }),
-        format.splat(),
-        format.json()
-    ),
-    defaultMeta: { service: 'dockerhub-mcp-server' },
-    transports: [],
-});
+export function initLogger(logsDir?: string) {
+    logger = winston.createLogger({
+        level: 'info',
+        format: format.combine(
+            format.timestamp({
+                format: 'YYYY-MM-DD HH:mm:ss',
+            }),
+            format.errors({ stack: true }),
+            format.splat(),
+            format.json()
+        ),
+        defaultMeta: { service: 'dockerhub-mcp-server' },
+        transports: [],
+    });
 
-//
-// If we're not in production then log to the `console` with the format:
-// `${info.level}: ${info.message} JSON.stringify({ ...rest }) `
+    if (process.env.NODE_ENV === 'production' && !logsDir) {
+        logsDir = '/app/logs';
+        console.warn(`logs dir unspecified, defaulting to ${logsDir}`);
+    }
 
-if (process.env.NODE_ENV !== 'production') {
-    logger.add(
-        new winston.transports.Console({
-            format: winston.format.simple(),
-            log: (info) => {
-                console.error(info.message);
-            },
-        })
-    );
-} else {
-    logger.transports.push(
-        //
-        // - Write all logs with importance level of `error` or higher to `error.log`
-        //   (i.e., error, fatal, but not other levels)
-        //
-        new winston.transports.File({ filename: 'logs/error.log', level: 'warn' }),
-        //
-        // - Write all logs with importance level of `info` or higher to `combined.log`
-        //   (i.e., fatal, error, warn, and info, but not trace)
-        //
-        new winston.transports.File({ filename: 'logs/mcp.log', level: 'info' })
-    );
+    if (logsDir) {
+        logger.transports.push(
+            new winston.transports.File({
+                filename: path.join(logsDir, 'error.log'),
+                level: 'warn',
+            }),
+            new winston.transports.File({ filename: path.join(logsDir, 'mcp.log'), level: 'info' })
+        );
+    } else {
+        logger.add(
+            new winston.transports.Console({
+                format: winston.format.simple(),
+                log: (info) => {
+                    console.error(info.message);
+                },
+            })
+        );
+    }
 }