Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation for Buildkite package registry #819

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kleeadrian
Copy link

Added supported, instructions and steps on how to leverage GitHub Actions to push packages to Buildkite package registry.

Adrian Lee added 3 commits November 25, 2024 23:13
updated readme to include buildkite packages

Signed-off-by: Adrian Lee <[email protected]>
Signed-off-by: Adrian Lee <[email protected]>
Updated docs for buildkite package registry

Signed-off-by: Adrian Lee <[email protected]>
uses: docker/login-action@v3
with:
registry: packages.buildkite.com
username: buildkite #All usernames to buildkite packages is "buildkite".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't inline comment also doesn't look necessary as this is documented in buildkite docs already: https://buildkite.com/docs/package-registries/container#publish-an-image

Comment on lines +521 to +522
**Useful references:**
[Buildkite package Registry](https://buildkite.com/docs/package-registries)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not consistent with other examples. Let's keep the same layout.

@@ -494,6 +495,43 @@ jobs:
password: ${{ secrets.DIGITALOCEAN_ACCESS_TOKEN }}
```

### Buildkite Package Registry

Use your Buildkite registered email address to generate an API access token to authenticate. U
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo here:

Suggested change
Use your Buildkite registered email address to generate an API access token to authenticate. U
Use your Buildkite registered email address to generate an API access token to authenticate.

Also this looks like a copy/paste of DigitalOcean example and does not seem accurate looking at Buildkite docs. I think the following would be better to be consistent with other examples related to my previous comment:

Suggested change
Use your Buildkite registered email address to generate an API access token to authenticate. U
Configure [API access token](https://buildkite.com/user/api-access-tokens) to login to [Buildkite Package Registries](https://buildkite.com/docs/package-registries/container). Ensure this access token has the **Read Packages** and **Write Packages** REST API scopes.

Comment on lines +524 to +534
Go to your Buildkite Org/Buildkite Package registry to generate a token

**Working pipeline example:** [https://gist.github.com/kleeadrian/f096878f76b5fb759976adce9550c9a5](https://gist.github.com/kleeadrian/f096878f76b5fb759976adce9550c9a5)

**Scope required:**
```
read_registries
write_registries
read_packages
write_packages
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed based on my previous comment also we don't want to provide pipeline examples as the snippet here is enough to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants