Skip to content

Matrix build overwrites comments #52

Open
@rwaffen

Description

Hi,

when i build multiple containers in a gha matrix and also scan them, only one output from docker scout will end up in the comments. only the last (?) i think.

for reference see here:
voxpupuli/container-voxbox#38

I have to build two versions to support two software versions inside, and i want to scan and see the output of both.

cheers, Robert

Activity

eunomie

eunomie commented on Aug 23, 2024

@eunomie
Contributor

Hi @rwaffen

Thanks for reporting the issue.

Yes you're right, currently it will overwrite the existing comment.
You can try by setting keep-previous-comments: true (see https://github.com/docker/scout-action?tab=readme-ov-file#pull-request-comments) so it will add a new comment for each run. It's not a perfect solution as it will hide previous content behind a "Outdated" line but it might help short term by still keeping all the comments content.

I'll keep you posted once it will be fixed.

self-assigned this
on Aug 23, 2024
rwaffen

rwaffen commented on Aug 23, 2024

@rwaffen
Author

thx for the quick answer! it's not perfect, but something... thx :).

seeing forward to a general solution for this :)

cthtrifork

cthtrifork commented on Jan 14, 2025

@cthtrifork

We are also having this issue. We are using a matrix that executes a series of steps for a list of images. Each job invokes this action and the comments are overwriting eachother.

For reference it is a job that scans all image changes in the PR and does a scout compare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

    Participants

    @eunomie@rwaffen@cthtrifork

    Issue actions

      Matrix build overwrites comments · Issue #52 · docker/scout-action