Skip to content

Using registry mirrors was broken with v3.1 #163

Closed
@tedivm

Description

@tedivm

Contributing guidelines

I've found a bug, and:

  • The documentation does not mention anything about my problem
  • There are no open or closed issues that are related to my problem

Description

Starting in v3.1, which released the PR for #151, you've hardcoded the image registry to docker.io on the image itself.

This breaks everyone who is using an registry mirror, because it forces people to use your registry specifically while ignoring the possibility someone might want to use a mirror. This is even more critical because you've introduced rate limits to your registry.

The solution to #151 is not to force every user onto your registry, but to provide documentation for the REGISTRY_HOST environment variable so people can switch to it when they want.

Expected behaviour

If I'm using a registry mirror I want to actually use that mirror.

Actual behaviour

Instead of using our mirror we're being forced to the docker.io, which means we're being rate limited. This in turn means the action is breaking our pipelines.

Repository URL

No response

Workflow run URL

No response

YAML workflow

name: Container Build and Publish
run-name: Build and Push Docker Image
on:
  workflow_dispatch:
  pull_request:
  push:
    branches:
      - main
  release:


jobs:
  Build-and-Push:
    steps:
      # This step should use the configured mirror in our runners, but doesn't.
      - name: Set up QEMU
        uses: docker/[email protected]

Workflow logs

No response

BuildKit logs

Pulling binfmt Docker image
  /usr/bin/docker pull docker.io/tonistiigi/binfmt:latest
  Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
Error: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

Additional info

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions