Skip to content

Sync PR builds not occurring during CI on AppVeyor #106

Open
@atifaziz

Description

@atifaziz

Unfortunately, once PR #104 was merged, the build failed on master due to compilation errors:

C:\projects\docopt-net\src\DocoptNet\Docopt.cs(174,88): error CS1503: Argument 2: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(175,123): error CS1503: Argument 4: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(174,88): error CS1503: Argument 2: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(175,123): error CS1503: Argument 4: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(174,88): error CS1503: Argument 2: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(175,123): error CS1503: Argument 4: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(182,20): error CS8619: Nullability of reference types in value of type 'TSource[]' doesn't match target type 'IEnumerable<T>'. [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(174,88): error CS1503: Argument 2: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet.Playground\DocoptNet.Playground.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(175,123): error CS1503: Argument 4: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet.Playground\DocoptNet.Playground.csproj]

From what I understand, AppVeyor builds are triggered on:

  • push to branch
  • merge PR to branch
  • open PR
  • sync PR (when you do push to branch with open PR)

It seems that PR #105 was merged into master before, but did not trigger a build for PR #104 that was also targeting the same branch (sync PR case above). Had that happened then the build errors would have been caught before breaking master.

/cc @voieducode


📎 log.txt

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions