Merge pull request #771 from driehle/fix/broken-tests

driehle · web-flow · commit 0844e03d5362 · 2022-02-03T22:51:44.000+01:00
Fixed broken test cases occuring with laminas-test 3.8.0
diff --git a/composer.json b/composer.json
@@ -77,7 +77,7 @@
         "laminas/laminas-mvc-console": "^1.3.0",
         "laminas/laminas-serializer": "^2.11.0",
         "laminas/laminas-session": "^2.12.0",
-        "laminas/laminas-test": "^3.5.1",
+        "laminas/laminas-test": "^3.8.0",
         "phpspec/prophecy-phpunit": "^2.0.1",
         "phpstan/phpstan": "^1.1.2",
         "phpstan/phpstan-phpunit": "^1.0.0",
diff --git a/tests/Controller/CliControllerTest.php b/tests/Controller/CliControllerTest.php
@@ -40,8 +40,7 @@ protected function setUp(): void
      */
     public function testIndexActionCanBeAccessed(): void
     {
-        /** @phpstan-ignore-next-line */
-        $this->dispatch(new Request(['scriptname.php', 'list']));
+        $this->dispatch((string) (new Request(['scriptname.php', 'list'])));
 
         $this->assertResponseStatusCode(0);
         $this->assertModuleName('doctrinemodule');
@@ -53,16 +52,14 @@ public function testIndexActionCanBeAccessed(): void
 
     public function testNonZeroExitCode(): void
     {
-        /** @phpstan-ignore-next-line */
-        $this->dispatch(new Request(['scriptname.php', 'fail']));
+        $this->dispatch((string) (new Request(['scriptname.php', 'fail'])));
 
         $this->assertNotResponseStatusCode(0);
     }
 
     public function testException(): void
     {
-        /** @phpstan-ignore-next-line */
-        $this->dispatch(new Request(['scriptname.php', '-q', 'fail', '--exception']));
+        $this->dispatch((string) (new Request(['scriptname.php', '-q', 'fail', '--exception'])));
 
         $this->assertNotResponseStatusCode(0);
     }

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,7 @@ protected function setUp(): void`
`40`	`40`	`*/`
`41`	`41`	`public function testIndexActionCanBeAccessed(): void`
`42`	`42`	`{`
`43`		`- /** @phpstan-ignore-next-line */`
`44`		`- $this->dispatch(new Request(['scriptname.php', 'list']));`
	`43`	`+ $this->dispatch((string) (new Request(['scriptname.php', 'list'])));`
`45`	`44`
`46`	`45`	`$this->assertResponseStatusCode(0);`
`47`	`46`	`$this->assertModuleName('doctrinemodule');`
`@@ -53,16 +52,14 @@ public function testIndexActionCanBeAccessed(): void`
`53`	`52`
`54`	`53`	`public function testNonZeroExitCode(): void`
`55`	`54`	`{`
`56`		`- /** @phpstan-ignore-next-line */`
`57`		`- $this->dispatch(new Request(['scriptname.php', 'fail']));`
	`55`	`+ $this->dispatch((string) (new Request(['scriptname.php', 'fail'])));`
`58`	`56`
`59`	`57`	`$this->assertNotResponseStatusCode(0);`
`60`	`58`	`}`
`61`	`59`
`62`	`60`	`public function testException(): void`
`63`	`61`	`{`
`64`		`- /** @phpstan-ignore-next-line */`
`65`		`- $this->dispatch(new Request(['scriptname.php', '-q', 'fail', '--exception']));`
	`62`	`+ $this->dispatch((string) (new Request(['scriptname.php', '-q', 'fail', '--exception'])));`
`66`	`63`
`67`	`64`	`$this->assertNotResponseStatusCode(0);`
`68`	`65`	`}`