Merge pull request #646 from Erikvv/fix/strategy-before-type-conversion

Apply hydrator strategies before type conversion

Author: TomHAnderson

src/DoctrineModule/Stdlib/Hydrator/DoctrineObject.php

@@ -262,6 +262,19 @@ protected function extractByReference($object)
         return $data;
     }
 
+    /**
+     * Converts a value for hydration
+     * Apply strategies first, then the type conversions
+     *
+     * @inheritdoc
+     */
+    public function hydrateValue($name, $value, $data = null)
+    {
+        $value = parent::hydrateValue($name, $value, $data);
+
+        return $this->handleTypeConversions($value, $this->metadata->getTypeOfField($name));
+    }
+
     /**
      * Hydrate the object using a by-value logic (this means that it uses the entity API, in this
      * case, setters)
@@ -282,7 +295,6 @@ protected function hydrateByValue(array $data, $object)
 
         foreach ($data as $field => $value) {
             $field  = $this->computeHydrateFieldName($field);
-            $value  = $this->handleTypeConversions($value, $metadata->getTypeOfField($field));
             $setter = 'set' . Inflector::classify($field);
 
             if ($metadata->hasAssociation($field)) {
@@ -344,7 +356,6 @@ protected function hydrateByReference(array $data, $object)
                 continue;
             }
 
-            $value        = $this->handleTypeConversions($value, $metadata->getTypeOfField($field));
             $reflProperty = $refl->getProperty($field);
             $reflProperty->setAccessible(true);
 

tests/DoctrineModuleTest/Stdlib/Hydrator/Asset/ByValueDifferentiatorEntity.php

@@ -0,0 +1,46 @@
+<?php
+
+namespace DoctrineModuleTest\Stdlib\Hydrator\Asset;
+
+class ByValueDifferentiatorEntity
+{
+    /**
+     * @var int
+     */
+    protected $id;
+
+    /**
+     * @var string
+     */
+    protected $field;
+
+    public function setId($id)
+    {
+        $this->id = $id;
+    }
+
+    public function getId()
+    {
+        return $this->id;
+    }
+
+    public function setField($field, $modifyValue = true)
+    {
+        // Modify the value to illustrate the difference between by value and by reference
+        if ($modifyValue) {
+            $this->field = "From setter: $field";
+        } else {
+            $this->field = $field;
+        }
+    }
+
+    public function getField($modifyValue = true)
+    {
+        // Modify the value to illustrate the difference between by value and by reference
+        if ($modifyValue) {
+            return "From getter: $this->field";
+        } else {
+            return $this->field;
+        }
+    }
+}

tests/DoctrineModuleTest/Stdlib/Hydrator/Asset/ContextEntity.php

@@ -10,7 +10,7 @@ class OneToOneEntity
     protected $id;
 
     /**
-     * @var SimpleEntity
+     * @var ByValueDifferentiatorEntity
      */
     protected $toOne;
 
@@ -25,7 +25,7 @@ public function getId()
         return $this->id;
     }
 
-    public function setToOne(SimpleEntity $entity = null, $modifyValue = true)
+    public function setToOne(ByValueDifferentiatorEntity $entity = null, $modifyValue = true)
     {
         // Modify the value to illustrate the difference between by value and by reference
         if ($modifyValue && $entity !== null) {

tests/DoctrineModuleTest/Stdlib/Hydrator/Asset/OneToOneEntity.php

@@ -10,7 +10,7 @@ class OneToOneEntityNotNullable
     protected $id;
 
     /**
-     * @var SimpleEntity
+     * @var ByValueDifferentiatorEntity
      */
     protected $toOne;
 
@@ -25,7 +25,7 @@ public function getId()
         return $this->id;
     }
 
-    public function setToOne(SimpleEntity $entity, $modifyValue = true)
+    public function setToOne(ByValueDifferentiatorEntity $entity, $modifyValue = true)
     {
         // Modify the value to illustrate the difference between by value and by reference
         if ($modifyValue) {

tests/DoctrineModuleTest/Stdlib/Hydrator/Asset/OneToOneEntityNotNullable.php

@@ -24,23 +24,13 @@ public function getId()
         return $this->id;
     }
 
-    public function setField($field, $modifyValue = true)
+    public function setField($field)
     {
-        // Modify the value to illustrate the difference between by value and by reference
-        if ($modifyValue) {
-            $this->field = "From setter: $field";
-        } else {
-            $this->field = $field;
-        }
+        $this->field = $field;
     }
 
-    public function getField($modifyValue = true)
+    public function getField()
     {
-        // Modify the value to illustrate the difference between by value and by reference
-        if ($modifyValue) {
-            return "From getter: $this->field";
-        } else {
-            return $this->field;
-        }
+        return $this->field;
     }
 }