updated PhpStan to 1.0 and fixed newly occurring issues

Author: driehle

composer.json

@@ -66,16 +66,16 @@
     "require-dev": {
         "doctrine/coding-standard": "^9.0.0",
         "doctrine/orm": "^2.10.2",
-        "jangregor/phpstan-prophecy": "^0.8.1",
+        "jangregor/phpstan-prophecy": "^1.0.0",
         "laminas/laminas-i18n": "^2.11.3",
         "laminas/laminas-log": "^2.13.1",
         "laminas/laminas-mvc-console": "^1.3.0",
         "laminas/laminas-serializer": "^2.11.0",
         "laminas/laminas-session": "^2.12.0",
         "laminas/laminas-test": "^3.5.1",
         "phpspec/prophecy-phpunit": "^2.0.1",
-        "phpstan/phpstan": "^0.12.99",
-        "phpstan/phpstan-phpunit": "^0.12.22",
+        "phpstan/phpstan": "^1.1.2",
+        "phpstan/phpstan-phpunit": "^1.0.0",
         "phpunit/phpunit": "^9.5.10",
         "predis/predis": "^1.1.9",
         "vimeo/psalm": "^4.11.2"

phpstan.neon

@@ -7,6 +7,10 @@ parameters:
         - src/Form/Element/ObjectMultiCheckboxV2Polyfill.php
         - src/Form/Element/ObjectRadioV2Polyfill.php
         - src/Form/Element/ObjectSelectV2Polyfill.php
+    ignoreErrors:
+        -
+            message: '#Property DoctrineModule\\Module::\$serviceManager is never read, only written.#'
+            path: src/Module.php
 includes:
     - vendor/phpstan/phpstan-phpunit/rules.neon
     - vendor/jangregor/phpstan-prophecy/extension.neon

src/Form/Element/Proxy.php

@@ -12,7 +12,6 @@
 use Laminas\Stdlib\Guard\ArrayOrTraversableGuardTrait;
 use ReflectionMethod;
 use RuntimeException;
-use Traversable;
 
 use function array_change_key_case;
 use function array_key_exists;
@@ -35,7 +34,7 @@ class Proxy implements ObjectManagerAwareInterface
 {
     use ArrayOrTraversableGuardTrait;
 
-    /** @var mixed[]|Traversable */
+    /** @var mixed[] */
     protected $objects;
 
     /** @var ?string */

tests/Form/Element/ProxyAwareElementTestCase.php

@@ -22,7 +22,7 @@ class ProxyAwareElementTestCase extends TestCase
     /** @var MockObject&ClassMetadata */
     protected $metadata;
 
-    /** @var MockObject */
+    /** @var object */
     protected $element;
 
     /** @var ArrayCollection */

tests/ModuleTest.php

@@ -14,6 +14,8 @@
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
+use function assert;
+use function method_exists;
 use function serialize;
 use function unserialize;
 
@@ -110,6 +112,7 @@ public function testGetConsoleUsage(): void
             }));
 
         $module = new Module();
+        assert(method_exists($module, 'getConsoleUsage'));
 
         $module->onBootstrap($this->event);