Dependency Injection and ODM Filter

[t-veron]

Hello,

Did you plan to add the possibility to inject services in filters?

In fact, actually we can only inject static parameters.

This bundle MongodbOdmFiltersBundle add this functionnality.

[malarzm]

This makes sense, however given latest trends I think we should either allow pointing to a service or somehow discover the filters and autoconfigure them. The first option seems to be easier and leaves the door opened for the 2nd one so I think it might be better. So instead of injecting services manually like in the bundle you've linked we could leverage autowiring and start with

filters:
    Some\Filter:
        class: Some\Filter
        service: true

aiming to have simpler construct in the future for enabled filters.

filters:
    Some\Filter: ~

This however would require reworking a bit filters to accept instance of a filter instead of class name.

Having said that, injecting services as parameters might be easier for first step, a PR will be appreciated!

[t-veron]

I'm agree with you.

However I analysed the code of doctrine/mongodb-odm and we can't use directly dependancy injection because they create new objects from constructor call's.

  public function enable(string $name) : BsonFilter
    {
        if (! $this->has($name)) {
            throw new InvalidArgumentException("Filter '" . $name . "' does not exist.");
        }
        if (! $this->isEnabled($name)) {
            $filterClass      = $this->config->getFilterClassName($name);
            $filterParameters = $this->config->getFilterParameters($name);
            **$filter           = new $filterClass($this->dm);**
            foreach ($filterParameters as $param => $value) {
                $filter->setParameter($param, $value);
            }
            $this->enabledFilters[$name] = $filter;
        }
        return $this->enabledFilters[$name];
    }

[malarzm]

Yeah, I realized that by the time I was finishing my comment :)

Having said that, injecting services as parameters might be easier for first step, a PR will be appreciated!

[alcaeus]

I've created doctrine/mongodb-odm#1986 to track the refactoring of the filter logic to allow better configuration. Once this has been implemented in ODM we can then talk about using auto configuration and tags on services to tie filters to document managers 👍