Avoid mocks without expectations

derrabus · derrabus · commit 5c64814ca423 · 2026-02-04T18:11:57.000+01:00
diff --git a/tests/Connection/CachedQueryTest.php b/tests/Connection/CachedQueryTest.php
@@ -88,7 +88,7 @@ private function createConnection(int $expectedQueryCount, array $columnNames, a
             ->method('query')
             ->willReturnCallback(static fn (): ArrayResult => new ArrayResult($columnNames, $rows));
 
-        $driver = $this->createMock(Driver::class);
+        $driver = self::createStub(Driver::class);
         $driver->method('connect')
             ->willReturn($connection);
 
diff --git a/tests/ConnectionTest.php b/tests/ConnectionTest.php
@@ -183,12 +183,12 @@ public function testTransactionIsNotActiveAfterTransactionalInAutoCommitMode():
 
     public function testTransactionIsActiveAfterTransactionalInNoAutoCommitMode(): void
     {
-        $platformMock = $this->createMock(AbstractPlatform::class);
+        $platformMock = self::createStub(AbstractPlatform::class);
         $platformMock
             ->method('supportsSavepoints')
             ->willReturn(true);
 
-        $driverMock = $this->createMock(Driver::class);
+        $driverMock = self::createStub(Driver::class);
         $driverMock
             ->method('connect')
             ->willReturn(
@@ -470,7 +470,7 @@ public function testFetch(string $method, callable $invoke, mixed $expected): vo
             ->willReturn($expected);
 
         $driver = $this->createConfiguredMock(Driver::class, [
-            'connect' => $this->createMock(DriverConnection::class),
+            'connect' => self::createStub(DriverConnection::class),
         ]);
 
         $conn = $this->getMockBuilder(Connection::class)
@@ -565,7 +565,7 @@ public function testPlatformDetectionTriggersConnectionIfRequiredByTheDriver():
             ->method('getServerVersion')
             ->willReturn('6.6.6');
 
-        $platform = $this->createMock(AbstractPlatform::class);
+        $platform = self::createStub(AbstractPlatform::class);
 
         $driver = $this->createMock(Driver::class);
         $driver->expects(self::once())
@@ -590,7 +590,7 @@ public function testPlatformDetectionDoesNotTriggerConnectionIfNotRequiredByTheD
         $driverConnection->expects(self::never())
             ->method('getServerVersion');
 
-        $platform = $this->createMock(AbstractPlatform::class);
+        $platform = self::createStub(AbstractPlatform::class);
 
         $driver = $this->createMock(Driver::class);
         $driver->expects(self::never())
@@ -608,9 +608,9 @@ public function testPlatformDetectionFetchedFromParameters(): void
     {
         $driverMock = $this->createMock(Driver::class);
 
-        $driverConnectionMock = $this->createMock(Driver\Connection::class);
+        $driverConnectionMock = self::createStub(Driver\Connection::class);
 
-        $platformMock = $this->createMock(AbstractPlatform::class);
+        $platformMock = self::createStub(AbstractPlatform::class);
 
         $connection = new Connection(['serverVersion' => '8.0'], $driverMock);
 
@@ -630,9 +630,9 @@ public function testPlatformDetectionFetchedFromPrimaryReplicaParameters(): void
     {
         $driverMock = $this->createMock(Driver::class);
 
-        $driverConnectionMock = $this->createMock(Driver\Connection::class);
+        $driverConnectionMock = self::createStub(Driver\Connection::class);
 
-        $platformMock = $this->createMock(AbstractPlatform::class);
+        $platformMock = self::createStub(AbstractPlatform::class);
 
         $connection = new Connection(['primary' => ['serverVersion' => '8.0']], $driverMock);
 
@@ -650,7 +650,7 @@ public function testPlatformDetectionFetchedFromPrimaryReplicaParameters(): void
 
     public function testConnectionParamsArePassedToTheQueryCacheProfileInExecuteCacheQuery(): void
     {
-        $cacheItemMock = $this->createMock(CacheItemInterface::class);
+        $cacheItemMock = self::createStub(CacheItemInterface::class);
         $cacheItemMock->method('isHit')->willReturn(true);
         $cacheItemMock->method('get')->willReturn(['realKey' => [[], []]]);
 
@@ -682,7 +682,7 @@ public function testConnectionParamsArePassedToTheQueryCacheProfileInExecuteCach
             ->with($query, $params, $types, $expectedConnectionParams)
             ->willReturn(['cacheKey', 'realKey']);
 
-        $driver = $this->createMock(Driver::class);
+        $driver = self::createStub(Driver::class);
 
         (new Connection(self::CONNECTION_PARAMS, $driver))
             ->executeCacheQuery($query, $params, $types, $queryCacheProfileMock);
diff --git a/tests/Driver/Middleware/AbstractConnectionMiddlewareTest.php b/tests/Driver/Middleware/AbstractConnectionMiddlewareTest.php
@@ -14,7 +14,7 @@ final class AbstractConnectionMiddlewareTest extends TestCase
 {
     public function testPrepare(): void
     {
-        $statement  = $this->createMock(Statement::class);
+        $statement  = self::createStub(Statement::class);
         $connection = $this->createMock(Connection::class);
         $connection->expects(self::once())
             ->method('prepare')
@@ -26,7 +26,7 @@ public function testPrepare(): void
 
     public function testQuery(): void
     {
-        $result     = $this->createMock(Result::class);
+        $result     = self::createStub(Result::class);
         $connection = $this->createMock(Connection::class);
         $connection->expects(self::once())
             ->method('query')
diff --git a/tests/Driver/Middleware/AbstractDriverMiddlewareTest.php b/tests/Driver/Middleware/AbstractDriverMiddlewareTest.php
@@ -13,7 +13,7 @@ final class AbstractDriverMiddlewareTest extends TestCase
 {
     public function testConnect(): void
     {
-        $connection = $this->createMock(Connection::class);
+        $connection = self::createStub(Connection::class);
         $driver     = $this->createMock(Driver::class);
         $driver->expects(self::once())
             ->method('connect')
diff --git a/tests/Driver/Middleware/AbstractStatementMiddlewareTest.php b/tests/Driver/Middleware/AbstractStatementMiddlewareTest.php
@@ -13,7 +13,7 @@ final class AbstractStatementMiddlewareTest extends TestCase
 {
     public function testExecute(): void
     {
-        $result    = $this->createMock(Result::class);
+        $result    = self::createStub(Result::class);
         $statement = $this->createMock(Statement::class);
         $statement->expects(self::once())
             ->method('execute')
diff --git a/tests/DriverManagerTest.php b/tests/DriverManagerTest.php
@@ -41,7 +41,7 @@ public function testInvalidDriver(): void
     #[RequiresPhpExtension('sqlite3')]
     public function testCustomWrapper(): void
     {
-        $wrapper      = $this->createMock(Connection::class);
+        $wrapper      = self::createStub(Connection::class);
         $wrapperClass = $wrapper::class;
 
         $options = [
diff --git a/tests/Logging/MiddlewareTest.php b/tests/Logging/MiddlewareTest.php
@@ -18,9 +18,9 @@ class MiddlewareTest extends TestCase
 
     public function setUp(): void
     {
-        $connection = $this->createMock(Connection::class);
+        $connection = self::createStub(Connection::class);
 
-        $driver = $this->createMock(Driver::class);
+        $driver = self::createStub(Driver::class);
         $driver->method('connect')
             ->willReturn($connection);
 
diff --git a/tests/Portability/ConnectionTest.php b/tests/Portability/ConnectionTest.php
@@ -28,7 +28,7 @@ public function testGetNativeConnection(): void
         $nativeConnection = new class () {
         };
 
-        $driverConnection = $this->createMock(ConnectionInterface::class);
+        $driverConnection = self::createStub(ConnectionInterface::class);
         $driverConnection->method('getNativeConnection')
             ->willReturn($nativeConnection);
 
diff --git a/tests/Query/QueryBuilderTest.php b/tests/Query/QueryBuilderTest.php
@@ -38,7 +38,7 @@ protected function setUp(): void
         $this->conn->method('createExpressionBuilder')
            ->willReturnCallback(fn () => new ExpressionBuilder($this->conn));
 
-        $platform = $this->createMock(AbstractPlatform::class);
+        $platform = self::createStub(AbstractPlatform::class);
         $platform->method('getUnionSelectPartSQL')
             ->willReturnArgument(0);
         $platform->method('getUnionAllSQL')
diff --git a/tests/Schema/ColumnTest.php b/tests/Schema/ColumnTest.php
@@ -73,7 +73,7 @@ public function testSettingUnknownOptionIsStillSupported(): void
         $this->expectException(UnknownColumnOption::class);
         $this->expectExceptionMessage('The "unknown_option" column option is not supported.');
 
-        new Column('foo', $this->createMock(Type::class), ['unknown_option' => 'bar']);
+        new Column('foo', self::createStub(Type::class), ['unknown_option' => 'bar']);
     }
 
     public function testOptionsShouldNotBeIgnored(): void
diff --git a/tests/Schema/MySQLInheritCharsetTest.php b/tests/Schema/MySQLInheritCharsetTest.php
@@ -81,7 +81,7 @@ public function testTableOptions(): void
      */
     private function getTableOptionsForOverride(array $params = []): array
     {
-        $driverMock = $this->createMock(Driver::class);
+        $driverMock = self::createStub(Driver::class);
 
         $platform = new MySQLPlatform();
         $conn     = new Connection($params, $driverMock, new Configuration());
diff --git a/tests/Schema/SQLiteSchemaManagerTest.php b/tests/Schema/SQLiteSchemaManagerTest.php
@@ -18,7 +18,7 @@ class SQLiteSchemaManagerTest extends TestCase
      */
     public function testListTableForeignKeysDefaultDatabasePassing(): void
     {
-        $conn = $this->createMock(Connection::class);
+        $conn = self::createStub(Connection::class);
         $conn->method('getDatabase')
             ->willReturn('main');
 
diff --git a/tests/Tools/DsnParserTest.php b/tests/Tools/DsnParserTest.php
@@ -185,7 +185,7 @@ public static function databaseUrls(): iterable
 
     public function testDriverClassScheme(): void
     {
-        $driverClass = get_class($this->createMock(Driver::class));
+        $driverClass = get_class(self::createStub(Driver::class));
         $parser      = new DsnParser(['custom' => $driverClass]);
         $actual      = $parser->parse('custom://foo:bar@localhost/baz');
 
diff --git a/tests/Types/BaseDateTypeTestCase.php b/tests/Types/BaseDateTypeTestCase.php
@@ -9,7 +9,7 @@
 use Doctrine\DBAL\Types\ConversionException;
 use Doctrine\DBAL\Types\Type;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\MockObject\Stub;
 use PHPUnit\Framework\TestCase;
 use stdClass;
 
@@ -18,15 +18,15 @@
 
 abstract class BaseDateTypeTestCase extends TestCase
 {
-    protected AbstractPlatform&MockObject $platform;
+    protected AbstractPlatform&Stub $platform;
     protected Type $type;
 
     /** @var non-empty-string */
     private string $currentTimezone;
 
     protected function setUp(): void
     {
-        $this->platform        = $this->createMock(AbstractPlatform::class);
+        $this->platform        = self::createStub(AbstractPlatform::class);
         $this->currentTimezone = date_default_timezone_get();
     }
 
diff --git a/tests/Types/BinaryTest.php b/tests/Types/BinaryTest.php
@@ -9,7 +9,7 @@
 use Doctrine\DBAL\Types\BinaryType;
 use Doctrine\DBAL\Types\ConversionException;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\MockObject\Stub;
 use PHPUnit\Framework\TestCase;
 
 use function array_map;
@@ -20,12 +20,12 @@
 
 class BinaryTest extends TestCase
 {
-    protected AbstractPlatform&MockObject $platform;
+    protected AbstractPlatform&Stub $platform;
     protected BinaryType $type;
 
     protected function setUp(): void
     {
-        $this->platform = $this->createMock(AbstractPlatform::class);
+        $this->platform = self::createStub(AbstractPlatform::class);
         $this->type     = new BinaryType();
     }
 
diff --git a/tests/Types/BlobTest.php b/tests/Types/BlobTest.php
@@ -6,17 +6,17 @@
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Types\BlobType;
-use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\MockObject\Stub;
 use PHPUnit\Framework\TestCase;
 
 class BlobTest extends TestCase
 {
-    protected AbstractPlatform&MockObject $platform;
+    protected AbstractPlatform&Stub $platform;
     protected BlobType $type;
 
     protected function setUp(): void
     {
-        $this->platform = $this->createMock(AbstractPlatform::class);
+        $this->platform = self::createStub(AbstractPlatform::class);
         $this->type     = new BlobType();
     }
 
diff --git a/tests/Types/ConversionExceptionTest.php b/tests/Types/ConversionExceptionTest.php
@@ -20,7 +20,7 @@ class ConversionExceptionTest extends TestCase
 {
     public function testConversionFailedPreviousException(): void
     {
-        $previous = $this->createMock(Throwable::class);
+        $previous = self::createStub(Throwable::class);
 
         $exception = ValueNotConvertible::new('foo', 'foo', null, $previous);
 
@@ -55,7 +55,7 @@ public function testConversionFailedInvalidTypeWithNonScalar(mixed $nonScalar):
 
     public function testConversionFailedInvalidTypePreviousException(): void
     {
-        $previous = $this->createMock(Throwable::class);
+        $previous = self::createStub(Throwable::class);
 
         $exception = InvalidType::new('foo', 'foo', ['bar', 'baz'], $previous);
 
@@ -64,7 +64,7 @@ public function testConversionFailedInvalidTypePreviousException(): void
 
     public function testConversionFailedFormatPreservesPreviousException(): void
     {
-        $previous = $this->createMock(Throwable::class);
+        $previous = self::createStub(Throwable::class);
 
         $exception = InvalidFormat::new('foo', 'bar', 'baz', $previous);
 
diff --git a/tests/Types/DateImmutableTypeTest.php b/tests/Types/DateImmutableTypeTest.php
@@ -6,6 +6,7 @@
 
 use DateTime;
 use DateTimeImmutable;
+use DateTimeZone;
 use Doctrine\DBAL\ParameterType;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Types\ConversionException;
@@ -36,15 +37,11 @@ public function testReturnsBindingType(): void
 
     public function testConvertsDateTimeImmutableInstanceToDatabaseValue(): void
     {
-        $date = $this->createMock(DateTimeImmutable::class);
+        $date = new DateTimeImmutable('2016-01-01 12:34:56', new DateTimeZone('UTC'));
 
         $this->platform->expects(self::once())
             ->method('getDateFormatString')
             ->willReturn('Y-m-d');
-        $date->expects(self::once())
-            ->method('format')
-            ->with('Y-m-d')
-            ->willReturn('2016-01-01');
 
         self::assertSame(
             '2016-01-01',
diff --git a/tests/Types/DateIntervalTest.php b/tests/Types/DateIntervalTest.php
@@ -10,18 +10,18 @@
 use Doctrine\DBAL\Types\ConversionException;
 use Doctrine\DBAL\Types\DateIntervalType;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\MockObject\Stub;
 use PHPUnit\Framework\TestCase;
 use stdClass;
 
 final class DateIntervalTest extends TestCase
 {
-    private AbstractPlatform&MockObject $platform;
+    private AbstractPlatform&Stub $platform;
     private DateIntervalType $type;
 
     protected function setUp(): void
     {
-        $this->platform = $this->createMock(AbstractPlatform::class);
+        $this->platform = self::createStub(AbstractPlatform::class);
         $this->type     = new DateIntervalType();
     }
 
diff --git a/tests/Types/DateTimeImmutableTypeTest.php b/tests/Types/DateTimeImmutableTypeTest.php
@@ -6,6 +6,7 @@
 
 use DateTime;
 use DateTimeImmutable;
+use DateTimeZone;
 use Doctrine\DBAL\ParameterType;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Types\ConversionException;
@@ -36,15 +37,11 @@ public function testReturnsBindingType(): void
 
     public function testConvertsDateTimeImmutableInstanceToDatabaseValue(): void
     {
-        $date = $this->createMock(DateTimeImmutable::class);
+        $date = new DateTimeImmutable('2016-01-01 15:58:59', new DateTimeZone('UTC'));
 
         $this->platform->expects(self::once())
             ->method('getDateTimeFormatString')
             ->willReturn('Y-m-d H:i:s');
-        $date->expects(self::once())
-            ->method('format')
-            ->with('Y-m-d H:i:s')
-            ->willReturn('2016-01-01 15:58:59');
 
         self::assertSame(
             '2016-01-01 15:58:59',
diff --git a/tests/Types/DateTimeTzImmutableTypeTest.php b/tests/Types/DateTimeTzImmutableTypeTest.php
@@ -6,6 +6,7 @@
 
 use DateTime;
 use DateTimeImmutable;
+use DateTimeZone;
 use Doctrine\DBAL\ParameterType;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Types\ConversionException;
@@ -36,15 +37,11 @@ public function testReturnsBindingType(): void
 
     public function testConvertsDateTimeImmutableInstanceToDatabaseValue(): void
     {
-        $date = $this->createMock(DateTimeImmutable::class);
+        $date = new DateTimeImmutable('2016-01-01 15:58:59', new DateTimeZone('UTC'));
 
         $this->platform->expects(self::once())
             ->method('getDateTimeTzFormatString')
             ->willReturn('Y-m-d H:i:s T');
-        $date->expects(self::once())
-            ->method('format')
-            ->with('Y-m-d H:i:s T')
-            ->willReturn('2016-01-01 15:58:59 UTC');
 
         self::assertSame(
             '2016-01-01 15:58:59 UTC',
diff --git a/tests/Types/DecimalTest.php b/tests/Types/DecimalTest.php
diff --git a/tests/Types/FloatTest.php b/tests/Types/FloatTest.php
diff --git a/tests/Types/GuidTypeTest.php b/tests/Types/GuidTypeTest.php
diff --git a/tests/Types/IntegerTest.php b/tests/Types/IntegerTest.php
diff --git a/tests/Types/NumberTest.php b/tests/Types/NumberTest.php
diff --git a/tests/Types/SmallFloatTest.php b/tests/Types/SmallFloatTest.php
diff --git a/tests/Types/SmallIntTest.php b/tests/Types/SmallIntTest.php
diff --git a/tests/Types/TimeImmutableTypeTest.php b/tests/Types/TimeImmutableTypeTest.php
diff --git a/tests/Types/VarDateTimeImmutableTypeTest.php b/tests/Types/VarDateTimeImmutableTypeTest.php
diff --git a/tests/Types/VarDateTimeTest.php b/tests/Types/VarDateTimeTest.php

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ final class AbstractConnectionMiddlewareTest extends TestCase`
`14`	`14`	`{`
`15`	`15`	`public function testPrepare(): void`
`16`	`16`	`{`
`17`		`- $statement = $this->createMock(Statement::class);`
	`17`	`+ $statement = self::createStub(Statement::class);`
`18`	`18`	`$connection = $this->createMock(Connection::class);`
`19`	`19`	`$connection->expects(self::once())`
`20`	`20`	`->method('prepare')`
`@@ -26,7 +26,7 @@ public function testPrepare(): void`
`26`	`26`
`27`	`27`	`public function testQuery(): void`
`28`	`28`	`{`
`29`		`- $result = $this->createMock(Result::class);`
	`29`	`+ $result = self::createStub(Result::class);`
`30`	`30`	`$connection = $this->createMock(Connection::class);`
`31`	`31`	`$connection->expects(self::once())`
`32`	`32`	`->method('query')`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ final class AbstractDriverMiddlewareTest extends TestCase`
`13`	`13`	`{`
`14`	`14`	`public function testConnect(): void`
`15`	`15`	`{`
`16`		`- $connection = $this->createMock(Connection::class);`
	`16`	`+ $connection = self::createStub(Connection::class);`
`17`	`17`	`$driver = $this->createMock(Driver::class);`
`18`	`18`	`$driver->expects(self::once())`
`19`	`19`	`->method('connect')`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ final class AbstractStatementMiddlewareTest extends TestCase`
`13`	`13`	`{`
`14`	`14`	`public function testExecute(): void`
`15`	`15`	`{`
`16`		`- $result = $this->createMock(Result::class);`
	`16`	`+ $result = self::createStub(Result::class);`
`17`	`17`	`$statement = $this->createMock(Statement::class);`
`18`	`18`	`$statement->expects(self::once())`
`19`	`19`	`->method('execute')`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function testInvalidDriver(): void`
`41`	`41`	`#[RequiresPhpExtension('sqlite3')]`
`42`	`42`	`public function testCustomWrapper(): void`
`43`	`43`	`{`
`44`		`- $wrapper = $this->createMock(Connection::class);`
	`44`	`+ $wrapper = self::createStub(Connection::class);`
`45`	`45`	`$wrapperClass = $wrapper::class;`
`46`	`46`
`47`	`47`	`$options = [`
Original file line number	Diff line number	Diff line change
`@@ -18,9 +18,9 @@ class MiddlewareTest extends TestCase`
`18`	`18`
`19`	`19`	`public function setUp(): void`
`20`	`20`	`{`
`21`		`- $connection = $this->createMock(Connection::class);`
	`21`	`+ $connection = self::createStub(Connection::class);`
`22`	`22`
`23`		`- $driver = $this->createMock(Driver::class);`
	`23`	`+ $driver = self::createStub(Driver::class);`
`24`	`24`	`$driver->method('connect')`
`25`	`25`	`->willReturn($connection);`
`26`	`26`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public function testSettingUnknownOptionIsStillSupported(): void`
`73`	`73`	`$this->expectException(UnknownColumnOption::class);`
`74`	`74`	`$this->expectExceptionMessage('The "unknown_option" column option is not supported.');`
`75`	`75`
`76`		`- new Column('foo', $this->createMock(Type::class), ['unknown_option' => 'bar']);`
	`76`	`+ new Column('foo', self::createStub(Type::class), ['unknown_option' => 'bar']);`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`public function testOptionsShouldNotBeIgnored(): void`