Merge pull request #1454 from greg0ire/consistency

Be consistent with how we deal with preg_match's return type

Author: greg0ire

src/Generator/Generator.php

@@ -9,7 +9,6 @@
 use Doctrine\Migrations\Tools\Console\Helper\MigrationDirectoryHelper;
 use InvalidArgumentException;
 
-use function assert;
 use function explode;
 use function file_get_contents;
 use function file_put_contents;
@@ -75,14 +74,11 @@ public function generateMigration(
         string|null $up = null,
         string|null $down = null,
     ): string {
-        $mch         = [];
-        $matchResult = preg_match('~(.*)\\\\([^\\\\]+)~', $fqcn, $mch);
-        if ($matchResult === 0) {
+        $mch = [];
+        if (preg_match('~(.*)\\\\([^\\\\]+)~', $fqcn, $mch) !== 1) {
             throw new InvalidArgumentException(sprintf('Invalid FQCN'));
         }
 
-        assert($matchResult !== false);
-
         [$fqcn, $namespace, $className] = $mch;
 
         $dirs = $this->configuration->getMigrationDirectories();