Merge pull request #1503 from alcaeus/fix-non-null-empty-ids

Allow creating references to "empty" identifiers

Author: alcaeus

lib/Doctrine/ODM/MongoDB/DocumentManager.php

@@ -675,7 +675,7 @@ public function createDBRef($document, array $referenceMapping = null)
         $class = $this->getClassMetadata(get_class($document));
         $id = $this->unitOfWork->getDocumentIdentifier($document);
 
-        if ( ! $id) {
+        if ($id === null) {
             throw new \RuntimeException(
                 sprintf('Cannot create a DBRef for class %s without an identifier. Have you forgotten to persist/merge the document first?', $class->name)
             );

tests/Doctrine/ODM/MongoDB/Tests/DocumentManagerTest.php

@@ -196,6 +196,17 @@ public function testCannotCreateDbRefWithoutId()
         $this->dm->createDBRef($d);
     }
 
+    public function testCreateDbRefWithNonNullEmptyId()
+    {
+        $phonenumber = new \Documents\CmsPhonenumber();
+        $phonenumber->phonenumber = 0;
+        $this->dm->persist($phonenumber);
+
+        $dbRef = $this->dm->createDBRef($phonenumber);
+
+        $this->assertSame(array('$ref' => 'CmsPhonenumber', '$id' => 0, '$db' => DOCTRINE_MONGODB_DATABASE), $dbRef);
+    }
+
     /**
      * @expectedException \Doctrine\ODM\MongoDB\Mapping\MappingException
      * @expectedExceptionMessage Simple reference must not target document using Single Collection Inheritance, Documents\Tournament\Participant targeted.