Skip to content

Commit 026f5bf

Browse files
authored
Merge pull request #12350 from greg0ire/missing-order-by
Add missing ORDER BY clause
2 parents d2418ab + 0b0f2f4 commit 026f5bf

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

tests/Tests/ORM/Functional/PaginationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ public function testPaginationWithSubSelectOrderByExpression($useOutputWalker, $
673673

674674
public function testDifferentResultLengthsDoNotRequireExtraQueryCacheEntries(): void
675675
{
676-
$dql = 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id >= :id';
676+
$dql = 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id >= :id ORDER BY u.id';
677677
$query = $this->_em->createQuery($dql);
678678
$query->setMaxResults(10);
679679

tests/Tests/ORM/Functional/Ticket/DDC1452Test.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function testIssue(): void
4949
$this->_em->flush();
5050
$this->_em->clear();
5151

52-
$dql = 'SELECT a, b, ba FROM ' . __NAMESPACE__ . '\DDC1452EntityA AS a LEFT JOIN a.entitiesB AS b LEFT JOIN b.entityATo AS ba';
52+
$dql = 'SELECT a, b, ba FROM ' . __NAMESPACE__ . '\DDC1452EntityA AS a LEFT JOIN a.entitiesB AS b LEFT JOIN b.entityATo AS ba ORDER BY a.id';
5353
$results = $this->_em->createQuery($dql)->setMaxResults(1)->getResult();
5454

5555
self::assertSame($results[0], $results[0]->entitiesB[0]->entityAFrom);

0 commit comments

Comments
 (0)