Skip to content

Commit 111898a

Browse files
committed
Mark test as incomplete
So that we can check if they're still relevant and, if so, adapt them.
1 parent a0342c8 commit 111898a

File tree

3 files changed

+16
-0
lines changed

3 files changed

+16
-0
lines changed

tests/Doctrine/Tests/ORM/Functional/Ticket/GH6682Test.php

+5
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ final class GH6682Test extends OrmFunctionalTestCase
1212
*/
1313
public function testIssue() : void
1414
{
15+
self::markTestIncomplete(
16+
'@guilhermeblanco, in #6683 we added allocationSize/initialValue as to the sequence definition but with the'
17+
. ' changes you have made I am not sure if we should rather test this relying on the mapping drivers instead'
18+
);
19+
1520
$parsedDefinition = [
1621
'sequenceName' => 'test_sequence',
1722
'allocationSize' => '',

tests/Doctrine/Tests/ORM/Mapping/ClassMetadataTest.php

+6
Original file line numberDiff line numberDiff line change
@@ -1407,6 +1407,12 @@ public function testManyToManySelfReferencingNamingStrategyDefaults()
14071407
*/
14081408
public function testQuotedSequenceName() : void
14091409
{
1410+
self::markTestIncomplete(
1411+
'@guilhermeblanco, in #6683 we added allocationSize/initialValue as to the sequence definition but with the'
1412+
. ' changes you have made I am not sure if the "initialValue" should still be verified here or if it should'
1413+
. ' part of the metadata drivers'
1414+
);
1415+
14101416
$cm = new ClassMetadata(CMS\CmsUser::class, $this->metadataBuildingContext);
14111417
$cm->setTable(new Mapping\TableMetadata('cms_users'));
14121418

tests/Doctrine/Tests/ORM/UnitOfWorkTest.php

+5
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,11 @@ public function testChangeTrackingNotify()
218218

219219
public function testChangeTrackingNotifyIndividualCommit()
220220
{
221+
self::markTestIncomplete(
222+
'@guilhermeblanco, this test was added directly on master#a16dc65cd206aed67a01a19f01f6318192b826af and'
223+
. ' since we do not support committing individual entities I think it is invalid now...'
224+
);
225+
221226
$persister = new EntityPersisterMock($this->emMock, $this->emMock->getClassMetadata("Doctrine\Tests\ORM\NotifyChangedEntity"));
222227
$this->unitOfWork->setEntityPersister('Doctrine\Tests\ORM\NotifyChangedEntity', $persister);
223228
$itemPersister = new EntityPersisterMock($this->emMock, $this->emMock->getClassMetadata("Doctrine\Tests\ORM\NotifyChangedRelatedItem"));

0 commit comments

Comments
 (0)