do not call isPrimary() with DBAL 4.3, check for PrimaryKeyConstraint instead

Author: xabbuh

Diff for: src/Mapping/Driver/DatabaseDriver.php

@@ -6,6 +6,7 @@
 
 use Doctrine\DBAL\Schema\AbstractSchemaManager;
 use Doctrine\DBAL\Schema\Column;
+use Doctrine\DBAL\Schema\PrimaryKeyConstraint;
 use Doctrine\DBAL\Schema\SchemaException;
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\DBAL\Types\Type;
@@ -305,7 +306,7 @@ private function buildIndexes(ClassMetadata $metadata): void
         $indexes   = $this->tables[$tableName]->getIndexes();
 
         foreach ($indexes as $index) {
-            if ($index->isPrimary()) {
+            if ($index instanceof PrimaryKeyConstraint || $index->isPrimary()) {
                 continue;
             }
 

Diff for: src/Tools/SchemaTool.php

@@ -319,7 +319,13 @@ public function getSchemaFromMetadata(array $classes): Schema
             $primaryKey = $table->getIndex('primary');
 
             foreach ($table->getIndexes() as $idxKey => $existingIndex) {
-                if (! $existingIndex->isPrimary() && $primaryKey->spansColumns($existingIndex->getColumns())) {
+                if (class_exists(PrimaryKeyConstraint::class)) {
+                    $existingIndexIsPrimaryKeyConstraint = $existingIndex instanceof PrimaryKeyConstraint;
+                } else {
+                    $existingIndexIsPrimaryKeyConstraint = $existingIndex->isPrimary();
+                }
+
+                if (! $existingIndexIsPrimaryKeyConstraint && $primaryKey->spansColumns($existingIndex->getColumns())) {
                     $table->dropIndex($idxKey);
                 }
             }

Diff for: tests/Tests/ORM/Tools/SchemaToolTest.php

@@ -5,6 +5,7 @@
 namespace Doctrine\Tests\ORM\Tools;
 
 use Doctrine\Common\Collections\Collection;
+use Doctrine\DBAL\Schema\PrimaryKeyConstraint;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\Mapping\Column;
 use Doctrine\ORM\Mapping\Entity;
@@ -42,6 +43,7 @@
 use Doctrine\Tests\OrmTestCase;
 use PHPUnit\Framework\Attributes\Group;
 
+use function class_exists;
 use function count;
 use function current;
 
@@ -232,7 +234,12 @@ public function testRemoveUniqueIndexOverruledByPrimaryKey(): void
         $indexes = $schema->getTable('first_entity')->getIndexes();
 
         self::assertCount(1, $indexes, 'there should be only one index');
-        self::assertTrue(current($indexes)->isPrimary(), 'index should be primary');
+
+        if (class_exists(PrimaryKeyConstraint::class)) {
+            self::assertInstanceOf(PrimaryKeyConstraint::class, current($indexes), 'index should be primary');
+        } else {
+            self::assertTrue(current($indexes)->isPrimary(), 'index should be primary');
+        }
     }
 
     public function testSetDiscriminatorColumnWithoutLength(): void