Support composite & non-identifier generated values #6684

Majkl578 · 2017-09-03T21:54:33Z

enable generated values for composite identifiers
enable generated values for non-identifier fields
forbid IDENTITY in composite identifiers and on non-identifiers (not supported by platforms)

This is now possible thanks to f482d64.

Possible enhancements:

More platform-specific tests (i.e. sequences)?
Unsure about post-insert generators, should they be allowed? Or maybe removed in 3.0 as it really makes sense only for IDENTITY generator?

Closes #6422.
Closes #4704.
Closes #5416.
Closes #2400.

…rsisters

… being applied everywhere

…in Mapping Drivers

…roken tests

…ing saga). Renamed identity generator to become sequencing generators.

This tool reads and writes YAML files so it should be removed.

Ref: https://github.com/doctrine/doctrine2/pull/5932/files/0f76b969cd79301a75c48bdbde89b118255cf7e3..8f5ebd93c1b802a4a89d0f4dff3d1d62cad67684#r70573803

…s by next commit

…ling related to OO change.

… a single, unified structure generatorDefinition

…m UnitOfWork

…ine\ORM\Version`

Ref: doctrine#6653 (comment)

…lass Drop `Doctrine\ORM\Version`, using `PackageVersions\Version::getVersion("doctrine/orm")` instead, which is more reliable

…properties-generator Use Generators instead of AppendIterator for properties iteration

greg0ire · 2017-09-03T21:59:31Z

lib/Doctrine/ORM/Tools/SchemaTool.php

@@ -486,7 +486,7 @@ private function gatherColumn($classMetadata, FieldMetadata $fieldMetadata, Tabl
            $options['customSchemaOptions'] = $fieldOptions;
        }

-        if ($fieldMetadata->hasValueGenerator() && $fieldMetadata->getValueGenerator()->getType() === GeneratorType::IDENTITY && $classMetadata->getIdentifierFieldNames() == [$fieldName]) {
+        if ($fieldMetadata->hasValueGenerator() && $fieldMetadata->getValueGenerator()->getType() === GeneratorType::IDENTITY && in_array($fieldName, $classMetadata->getIdentifierFieldNames(), true)) {


This line could use one or more linebreaks :P

…rators

guilhermeblanco and others added 30 commits July 28, 2017 19:26

Moved Discriminator Column to OO approach and refactored a bit for pe…

9952131

…rsisters

Finalized changes to ensure everything breaking now is due to quoting…

1747acb

… being applied everywhere

Removed isVersioned property.

ad96156

Switched versionField to versionProperty

7656296

Removed the need for FielMetadata::$currentClass property

dadb0ee

Cosmetic

0a76215

Cosmetic

2b838c3

Removed isCascadeXXX

b5b9ea7

Breaking everything with start migration to use ClassMetadataBuilder …

a50a3f4

…in Mapping Drivers

More work related to ClassMetadataBuilder changes and some fixes to b…

0296ed1

…roken tests

Fixes to bugs and made test more consistent

a78db23

Fixes and implemented incomplete tests

28ea7c7

Fix for test

8aa78e8

Removed some methods from QuoteStrategy (beginning of the end of quot…

2382e49

…ing saga). Renamed identity generator to become sequencing generators.

Removing Doctrine ORM 1 schema conversion tool.

4e95419

This tool reads and writes YAML files so it should be removed.

Removing YAML class metadata exporter and its references.

e98dd36

Removing YAML drivers and all its references.

dac8373

Removing YAML mappings on docblocks and messages.

b3c115f

Adding YAML removal as BC break.

b92c7a9

s/should/**MUST** as per @afoeder's review

f91a62b

Ref: https://github.com/doctrine/doctrine2/pull/5932/files/0f76b969cd79301a75c48bdbde89b118255cf7e3..8f5ebd93c1b802a4a89d0f4dff3d1d62cad67684#r70573803

More work around JoinColumns. Should start AssociationMetadata change…

7ff9857

…s by next commit

Introduced JoinColumnMetadata and refactored most tests. Still 14 fai…

fa9d0b8

…ling related to OO change.

Starting the concept of Builders on Drivers

3ff0afc

Fixing remaining possible to be fixed unit tests

9314d0e

Strict types

252b0fe

Merged sequenceGeneratorDefinition and customGeneratorDefinition into…

db6c704

… a single, unified structure generatorDefinition

Checks for references, proxies and retrievals on EM. Removed todo fro…

a843991

…m UnitOfWork

Simplified property inheritance logic when loading class metadata

f9ad31a

Moved FieldMetadata creation out of ClassMetadata

96b90a5

Allow unique index creation from ORM mapping

f15be6c

Ocramius and others added 5 commits August 28, 2017 19:58

doctrine#6653 adding note to UPGRADE.md about the removal of `Doctr…

b330e15

…ine\ORM\Version`

doctrine#6653 removing unused variable as per @alcaeus' review

7a094c8

Ref: doctrine#6653 (comment)

Merge pull request doctrine#6653 from doctrine/cleanup/drop-version-c…

333bf85

…lass Drop `Doctrine\ORM\Version`, using `PackageVersions\Version::getVersion("doctrine/orm")` instead, which is more reliable

Use Generators instead of AppendIterator for properties iteration

dba197a

Merge pull request doctrine#6663 from Majkl578/dev/ComponentMetadata-…

7f14a90

…properties-generator Use Generators instead of AppendIterator for properties iteration

Majkl578 added Improvement New Feature WIP labels Sep 3, 2017

Majkl578 added this to the 3.0 milestone Sep 3, 2017

greg0ire reviewed Sep 3, 2017

View reviewed changes

Majkl578 force-pushed the dev/composite-generated-values branch from 00bc67a to f5d58be Compare September 3, 2017 22:36

Majkl578 added 2 commits September 4, 2017 00:37

Enable multiple value generators per entity

4490b3b

Forbid composite or non-primary IDENTITY generators on single entity

3b441a4

Majkl578 force-pushed the dev/composite-generated-values branch from f5d58be to 1dbd8dc Compare September 3, 2017 22:38

Majkl578 changed the title ~~[WIP] Support composite & non-identifier generated values~~ Support composite & non-identifier generated values Sep 3, 2017

Majkl578 removed the WIP label Sep 3, 2017

Majkl578 requested review from Ocramius and guilhermeblanco September 3, 2017 22:43

Majkl578 added 3 commits September 4, 2017 01:00

Added test for non-identifier generators

e462794

Added test for generators in inheritance

f135146

Added test with composite identifier with association and custom gene…

9c82046

…rators

Majkl578 force-pushed the dev/composite-generated-values branch from c6a6212 to 9c82046 Compare September 3, 2017 23:00

guilhermeblanco force-pushed the develop branch from 9f5fd37 to e7d61c2 Compare December 4, 2017 00:36

lcobucci force-pushed the develop branch from 5c2ff27 to cebe300 Compare December 31, 2017 18:27

Majkl578 added the Rebase needed label Jan 1, 2018

Majkl578 changed the base branch from develop to master January 2, 2018 20:31

Somrlik mentioned this pull request Jul 8, 2018

Bug if you want to have an AUTO_INCREMENT id and an UUID #7215

Closed

Majkl578 closed this Apr 16, 2019

Majkl578 deleted the dev/composite-generated-values branch April 16, 2019 19:51

greg0ire removed this from the 3.0.0 milestone Jun 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support composite & non-identifier generated values #6684

Support composite & non-identifier generated values #6684

Majkl578 commented Sep 3, 2017 •

edited

Loading

greg0ire Sep 3, 2017

Support composite & non-identifier generated values #6684

Support composite & non-identifier generated values #6684

Conversation

Majkl578 commented Sep 3, 2017 • edited Loading

greg0ire Sep 3, 2017

Choose a reason for hiding this comment

Majkl578 commented Sep 3, 2017 •

edited

Loading