Skip to content

Commit d689cbc

Browse files
committed
Normalized remaining space options into settings admin
Moved space naming and category management into space settings.
1 parent 2953427 commit d689cbc

16 files changed

+174
-331
lines changed

gui/app/components/folder/category-admin-sidebar.js

Lines changed: 0 additions & 45 deletions
This file was deleted.

gui/app/components/folder/category-admin.js renamed to gui/app/components/folder/settings-category.js

Lines changed: 34 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,18 @@ import { A } from '@ember/array';
1414
import { inject as service } from '@ember/service';
1515
import TooltipMixin from '../../mixins/tooltip';
1616
import ModalMixin from '../../mixins/modal';
17+
import Notifer from '../../mixins/notifier';
1718
import Component from '@ember/component';
1819

19-
export default Component.extend(ModalMixin, TooltipMixin, {
20+
export default Component.extend(ModalMixin, TooltipMixin, Notifer, {
2021
spaceSvc: service('folder'),
2122
groupSvc: service('group'),
2223
categorySvc: service('category'),
2324
appMeta: service(),
2425
store: service(),
2526
deleteId: '',
2627
dropdown: null,
28+
newCategory: '',
2729

2830
init() {
2931
this._super(...arguments);
@@ -43,11 +45,11 @@ export default Component.extend(ModalMixin, TooltipMixin, {
4345

4446
load() {
4547
// get categories
46-
this.get('categorySvc').getAll(this.get('folder.id')).then((c) => {
48+
this.get('categorySvc').getAll(this.get('space.id')).then((c) => {
4749
this.set('category', c);
4850

4951
// get summary of documents and users for each category in space
50-
this.get('categorySvc').getSummary(this.get('folder.id')).then((s) => {
52+
this.get('categorySvc').getSummary(this.get('space.id')).then((s) => {
5153
c.forEach((cat) => {
5254
let docs = _.where(s, {categoryId: cat.get('id'), type: 'documents'});
5355
let docCount = 0;
@@ -67,7 +69,7 @@ export default Component.extend(ModalMixin, TooltipMixin, {
6769
permissionRecord(who, whoId, name) {
6870
let raw = {
6971
id: whoId,
70-
orgId: this.get('folder.orgId'),
72+
orgId: this.get('space.orgId'),
7173
categoryId: this.get('currentCategory.id'),
7274
whoId: whoId,
7375
who: who,
@@ -91,6 +93,31 @@ export default Component.extend(ModalMixin, TooltipMixin, {
9193
},
9294

9395
actions: {
96+
onAdd(e) {
97+
e.preventDefault();
98+
99+
let cat = this.get('newCategory');
100+
101+
if (cat === '') {
102+
$('#new-category-name').addClass('is-invalid').focus();
103+
return;
104+
}
105+
106+
$('#new-category-name').removeClass('is-invalid').focus();
107+
this.set('newCategory', '');
108+
109+
let c = {
110+
category: cat,
111+
folderId: this.get('space.id')
112+
};
113+
114+
this.showWait();
115+
this.get('categorySvc').add(c).then(() => {
116+
this.load();
117+
this.showDone();
118+
});
119+
},
120+
94121
onShowDelete(id) {
95122
let cat = this.get('category').findBy('id', id);
96123
this.set('deleteId', cat.get('id'));
@@ -144,7 +171,7 @@ export default Component.extend(ModalMixin, TooltipMixin, {
144171
this.set('categoryPermissions', categoryPermissions);
145172

146173
// get space permissions
147-
this.get('spaceSvc').getPermissions(this.get('folder.id')).then((spacePermissions) => {
174+
this.get('spaceSvc').getPermissions(this.get('space.id')).then((spacePermissions) => {
148175
spacePermissions.forEach((sp) => {
149176
let cp = this.permissionRecord(sp.get('who'), sp.get('whoId'), sp.get('name'));
150177
cp.set('selected', false);
@@ -172,11 +199,11 @@ export default Component.extend(ModalMixin, TooltipMixin, {
172199
onGrantAccess() {
173200
this.set('showCategoryAccess', false);
174201

175-
let folder = this.get('folder');
202+
let space = this.get('space');
176203
let category = this.get('currentCategory');
177204
let perms = this.get('categoryPermissions').filterBy('selected', true);
178205

179-
this.get('categorySvc').setViewers(folder.get('id'), category.get('id'), perms).then(() => {
206+
this.get('categorySvc').setViewers(space.get('id'), category.get('id'), perms).then(() => {
180207
this.load();
181208
});
182209
}

gui/app/components/folder/settings-general.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { A } from '@ember/array';
1313
import { inject as service } from '@ember/service';
1414
import { schedule } from '@ember/runloop';
1515
import { computed } from '@ember/object';
16+
import { empty } from '@ember/object/computed';
1617
import AuthMixin from '../../mixins/auth';
1718
import Notifier from '../../mixins/notifier';
1819
import Component from '@ember/component';
@@ -26,6 +27,8 @@ export default Component.extend(AuthMixin, Notifier, {
2627
return this.get('permissions.spaceOwner') || this.get('permissions.spaceManage');
2728
}),
2829

30+
spaceName: '',
31+
hasNameError: empty('spaceName'),
2932
spaceTypeOptions: A([]),
3033
spaceType: 0,
3134
likes: '',
@@ -51,6 +54,8 @@ export default Component.extend(AuthMixin, Notifier, {
5154
} else {
5255
this.set('likes', 'Did this help you?');
5356
}
57+
58+
this.set('spaceName', this.get('space.name'));
5459
},
5560

5661
actions: {
@@ -75,6 +80,10 @@ export default Component.extend(AuthMixin, Notifier, {
7580
let allowLikes = this.get('allowLikes');
7681
space.set('likes', allowLikes ? this.get('likes') : '');
7782

83+
let spaceName = this.get('spaceName').trim();
84+
if (spaceName.length === 0) return;
85+
space.set('name', spaceName);
86+
7887
this.showWait();
7988

8089
this.get('spaceSvc').save(space).then(() => {

gui/app/components/folder/space-heading.js

Lines changed: 0 additions & 54 deletions
This file was deleted.

gui/app/pods/folder/category/controller.js

Lines changed: 0 additions & 26 deletions
This file was deleted.

gui/app/pods/folder/category/route.js

Lines changed: 0 additions & 27 deletions
This file was deleted.

gui/app/pods/folder/category/template.hbs

Lines changed: 0 additions & 27 deletions
This file was deleted.

gui/app/pods/folder/index/template.hbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828

2929
{{#layout/middle-zone-sidebar}}
3030
<div id="sidebar" class="sidebar">
31-
{{folder/space-heading space=model.folder permissions=model.permissions}}
32-
3331
{{folder/space-view
3432
spaces=model.folders
3533
space=model.folder

gui/app/pods/folder/settings/template.hbs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@
3232
{{#if (eq tab 'blocks')}}
3333
{{folder/settings-blocks permissions=model.permissions space=model.folder}}
3434
{{/if}}
35+
36+
{{#if (eq tab 'categories')}}
37+
{{folder/settings-category permissions=model.permissions spaces=model.folder space=model.folder}}
38+
{{/if}}
3539
{{/layout/middle-zone-content}}
3640

3741
{{#layout/middle-zone-sidebar}}
@@ -42,7 +46,7 @@
4246
<li class="tab tab-vertical {{if (eq tab 'invitations') 'selected'}}" {{action 'onTab' 'invitations'}}>Invite Users</li>
4347
<li class="tab tab-vertical {{if (eq tab 'templates') 'selected'}}" {{action 'onTab' 'templates'}}>Document Templates</li>
4448
<li class="tab tab-vertical {{if (eq tab 'blocks') 'selected'}}" {{action 'onTab' 'blocks'}}>Content Blocks</li>
45-
<li class="tab tab-vertical" {{action 'onCategories'}}>Categories</li>
49+
<li class="tab tab-vertical {{if (eq tab 'categories') 'selected'}}" {{action 'onTab' 'categories'}}>Categories</li>
4650
</ul>
4751
</div>
4852
{{/layout/middle-zone-sidebar}}

gui/app/router.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,6 @@ export default Router.map(function () {
3535
path: 's/:folder_id/:folder_slug'
3636
},
3737
function () {
38-
this.route('category', {
39-
path: 'category'
40-
});
4138
this.route('settings', {
4239
path: 'settings'
4340
});

gui/app/templates/components/folder/category-admin-sidebar.hbs

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)