Skip to content

RequestMemory does not honor HTTP headers #245

@bosticka

Description

@bosticka

if I do this:

                new RequestMemory({
                    idProperty: 'id',
                    target: target
                    headers: { Authorization: 'Bearer abcd' }
                })

The bearer token for my JWT is not sent with the request and fails against an authenticated API.

I had to make two small changes to get this to work.

In RequestMemory.js:

postscript: function () {
			this.inherited(arguments);
			this.fetch();
		},

changed to:

postscript: function () {
			this.inherited(arguments);
			this.fetch(arguments[0]);
		},

and in Request.js:

		_request: function (kwArgs) {
			kwArgs = kwArgs || {};

			// perform the actual query
			var headers = lang.delegate(this.headers, { Accept: this.accepts });

changed to:

		_request: function (kwArgs) {
			kwArgs = kwArgs || {};

			// perform the actual query
			var headers = lang.mixin(this.headers, { Accept: this.accepts });

The lang.delegate breaks it somehow. It returns a TMP object and the passed in headers do not get mixed in and sent to the server.

Please consider merging these changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions