Skip to content

Commit d26de82

Browse files
committed
FileUploader: improve remove button label
1 parent e6417c9 commit d26de82

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/file-uploader/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ display of selected files as well as validation.
1515
### Keyboard features
1616

1717
- Trigger file selection dialog with keyboard
18-
- TODO Navigate file list with keyboard
18+
- Navigate to and activate buttons to remove files with keyboard
1919

2020
### i18n features
2121

src/file-uploader/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ export const FileUploader = factory(function FileUploader({
203203
remove(file);
204204
}}
205205
>
206-
<Icon type="closeIcon" altText={messages.remove} />
206+
<Icon type="closeIcon" altText={`${messages.remove} ${file.name}`} />
207207
</button>
208208
</div>
209209
{message && <div classes={[themeCss.validationMessage]}>{message}</div>}

src/file-uploader/tests/unit/FileUploader.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,11 @@ describe('FileUploader', function() {
9797
<div classes={[css.fileItemSize]}>{formatBytes(file.size)}</div>
9898
{index === 0 ? (
9999
<WrappedButton onclick={noop} classes={[css.closeButton]}>
100-
<Icon altText="Remove" type="closeIcon" />
100+
<Icon altText={`Remove ${file.name}`} type="closeIcon" />
101101
</WrappedButton>
102102
) : (
103103
<button onclick={noop} classes={[css.closeButton]}>
104-
<Icon altText="Remove" type="closeIcon" />
104+
<Icon altText={`Remove ${file.name}`} type="closeIcon" />
105105
</button>
106106
)}
107107
</div>

0 commit comments

Comments
 (0)