Merge pull request #1 from dojoengine/kronosapiens/team-role-decay

feat: exempt team role from sensei decay

Author: kronosapiens

backend/.env.example

@@ -12,6 +12,7 @@ KOHAI_ROLE_ID=your_kohai_role_id
 SENPAI_ROLE_ID=your_senpai_role_id
 SENSEI_ROLE_ID=your_sensei_role_id
 FELT_ROLE_ID=your_felt_role_id
+TEAM_ROLE_ID=your_team_role_id
 
 # Database (PostgreSQL connection string)
 DATABASE_URL=postgres://user:password@localhost:5432/daimyo

backend/.env.test

@@ -10,6 +10,7 @@ KOHAI_ROLE_ID=kohai-role-id
 SENPAI_ROLE_ID=senpai-role-id
 SENSEI_ROLE_ID=sensei-role-id
 FELT_ROLE_ID=felt-role-id
+TEAM_ROLE_ID=team-role-id
 
 DATABASE_PATH=:memory:
 

backend/__tests__/unit/decay.test.ts

@@ -31,6 +31,7 @@ jest.unstable_mockModule('../../src/utils/config.js', () => ({
     decayWindowDays: 360,
     senseiReactionThreshold: 30,
     feltRoleId: 'felt-role-id',
+    teamRoleId: 'team-role-id',
   },
 }));
 
@@ -183,6 +184,26 @@ describe('Decay Service', () => {
       expect(mockInsertRoleHistory).not.toHaveBeenCalled();
       expect(mockGetRecentSenseiReactions).not.toHaveBeenCalled();
     });
+
+    test('should not demote Sensei with Team role (core team exempt)', async () => {
+      const guild = createMockGuild();
+      const member = createMockMember('user-1', 'TestUser#0001', [
+        'sensei-role-id',
+        'team-role-id',
+      ]);
+      guild.members.cache.set('user-1', member);
+
+      mockGetUserRole.mockReturnValue(Role.Sensei);
+      // No reactions at all - would normally trigger demotion
+      mockGetRecentSenseiReactions.mockResolvedValue([]);
+
+      const result = await checkSenseiDecay(guild as any, 'user-1');
+
+      expect(result.demoted).toBe(false);
+      expect(mockAssignRole).not.toHaveBeenCalled();
+      expect(mockInsertRoleHistory).not.toHaveBeenCalled();
+      expect(mockGetRecentSenseiReactions).not.toHaveBeenCalled();
+    });
   });
 
   describe('getSenseiDecayStatus', () => {

backend/src/services/decay.ts

@@ -7,7 +7,7 @@ import { getUserRole, assignRole, sendDM, formatDemotionMessage } from './roleMa
 /**
  * Check if a Sensei should be demoted due to insufficient recent reactions
  * Sensei must maintain 30+ Sensei reactions within the last 360 days
- * Sensei with Felt role are exempt from decay (core group)
+ * Sensei with Felt or Team role are exempt from decay (core group)
  */
 export async function checkSenseiDecay(guild: Guild, userId: string): Promise<DemotionResult> {
   try {
@@ -18,12 +18,16 @@ export async function checkSenseiDecay(guild: Guild, userId: string): Promise<De
       return { demoted: false };
     }
 
-    // Sensei with Felt role are exempt from decay (core group)
+    // Sensei with Felt or Team role are exempt from decay (core group)
     const member = guild.members.cache.get(userId);
     if (member && config.feltRoleId && member.roles.cache.has(config.feltRoleId)) {
       console.debug(`Skipping decay check for ${userId}: has Felt role (core group)`);
       return { demoted: false };
     }
+    if (member && config.teamRoleId && member.roles.cache.has(config.teamRoleId)) {
+      console.debug(`Skipping decay check for ${userId}: has Team role (core group)`);
+      return { demoted: false };
+    }
 
     // Get Sensei reactions within the decay window
     const recentReactions = await getRecentSenseiReactions(userId, config.decayWindowDays);

backend/src/types.ts

@@ -52,6 +52,7 @@ export interface Config {
   senpaiRoleId: string;
   senseiRoleId: string;
   feltRoleId: string;
+  teamRoleId: string;
 
   // Channel IDs
   ohayoChannelId: string;

backend/src/utils/config.ts

@@ -56,6 +56,7 @@ export function loadConfig(): Config {
     senpaiRoleId: getRequiredEnv('SENPAI_ROLE_ID'),
     senseiRoleId: getRequiredEnv('SENSEI_ROLE_ID'),
     feltRoleId: getRequiredEnv('FELT_ROLE_ID'),
+    teamRoleId: getRequiredEnv('TEAM_ROLE_ID'),
 
     // Channel IDs
     ohayoChannelId: getRequiredEnv('OHAYO_CHANNEL_ID'),