Skip to content

Commit 890158b

Browse files
authored
Settings Menu Fix (#638)
* More consistent Rider New UI Scrollbars. * Fixed the settings window in builds 231.6890.12+
1 parent f9f7cd6 commit 890158b

7 files changed

Lines changed: 17 additions & 5 deletions

File tree

buildSrc/assets/templates/dark.scheme.template.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@
123123
<option name="ScrollBar.thumbBorderColor" value="%accentColor%5a"/>
124124
<option name="ScrollBar.thumbColor" value="%accentColor%5a"/>
125125
<option name="ScrollBar.trackColor" value="$textEditorBackground$"/>
126+
<option name="ScrollBar.background" value="$textEditorBackground$"/>
126127
<option name="TEARLINE_COLOR" value="$lineNumberColor$69"/>
127128
<option name="TOOLTIP" value="$textEditorBackground$"/>
128129
<option name="VCS_ANNOTATIONS_COLOR_1" value="$headerColor$"/>

buildSrc/assets/templates/light.scheme.template.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@
121121
<option name="ScrollBar.thumbBorderColor" value="%accentColor%5a"/>
122122
<option name="ScrollBar.thumbColor" value="%accentColor%5a"/>
123123
<option name="ScrollBar.trackColor" value="$textEditorBackground$"/>
124+
<option name="ScrollBar.background" value="$textEditorBackground$"/>
124125
<option name="TEARLINE_COLOR" value="$lineNumberColor$69"/>
125126
<option name="TOOLTIP" value="$textEditorBackground$"/>
126127
<option name="VCS_ANNOTATIONS_COLOR_1" value="$headerColor$"/>

changelog/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
Changelog
22
---
3+
4+
# 88.3-1.9.1 [Bug Fixes]
5+
6+
- Themed New UI Scrollbars in Rider to be consistent.
7+
- Fixed the settings window in builds `231.6890.12`+
8+
39
# 88.3-1.9.0 [EXP UI Search Field Fix]
410

511
- Vertically aligned the editor search text input on the new UI.

changelog/RELEASE-NOTES.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,6 @@
22
- Added the initial 2023.1 build support.
33
- Updated the border color of the `Code Lense` feature.
44
- Vertically aligned the editor search text input on the new UI.
5-
- Allow custom stickers to remain on IDE for non-Doki themes.
5+
- Allow custom stickers to remain on IDE for non-Doki themes.
6+
- Themed New UI Scrollbars in Rider to be consistent.
7+
- Fixed the settings window in builds `231.6890.12`+

gradle.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# -> https://www.jetbrains.org/intellij/sdk/docs/reference_guide/intellij_artifacts.html
33

44
pluginGroup=io.unthrottled
5-
pluginVersion=88.3-1.9.0
5+
pluginVersion=88.3-1.9.1
66
pluginSinceBuild=222
77
pluginUntilBuild = 231.*
88

@@ -32,7 +32,7 @@ idePrefix=IU
3232
idePath=
3333
#idePath=/Users/alexsimons/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/222.4167.29/IntelliJ IDEA 2022.1 EAP.app/Contents
3434
#idePath=C:\\Users\\birdm.DESKTOP-FO92PV5\\AppData\\Local\\JetBrains\\Toolbox\\apps\\DataSpell\\ch-0\\213.5744.251
35-
#idePath = /home/alex/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/203.7321754
35+
#idePath=/home/alex/.local/share/JetBrains/Toolbox/apps/AndroidStudio/ch-0/203.7321754
3636
#idePath=C:\\Users\\birdm.DESKTOP-FO92PV5\\AppData\\Local\\JetBrains\\Toolbox\\apps\\Rider\\ch-0\\212.4416.21
3737
#idePath=/home/alex/.local/share/JetBrains/Toolbox/apps/IDEA-U/ch-0/202.7660.26
3838
#idePath=/home/alex/.local/share/JetBrains/Toolbox/apps/PhpStorm/ch-0/193.5233.101

src/main/java/io/unthrottled/doki/settings/ThemeSettingsUI.form

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@
140140
<grid row="1" column="0" row-span="1" col-span="2" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
141141
</constraints>
142142
<properties>
143-
<icon value="actions/help.png"/>
144143
<text resource-bundle="messages/MessageBundle" key="settings.general.content.sticker.margin.info"/>
145144
</properties>
146145
</component>
@@ -446,7 +445,6 @@
446445
<grid row="1" column="0" row-span="1" col-span="1" vsize-policy="0" hsize-policy="0" anchor="8" fill="0" indent="0" use-parent-layout="false"/>
447446
</constraints>
448447
<properties>
449-
<icon value="general/warning.png"/>
450448
<text resource-bundle="messages/MessageBundle" key="settings.general.weeb.background.editor.info"/>
451449
</properties>
452450
</component>

src/main/java/io/unthrottled/doki/settings/ThemeSettingsUI.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package io.unthrottled.doki.settings;
22

3+
import com.intellij.icons.AllIcons;
34
import com.intellij.ide.BrowserUtil;
45
import com.intellij.ide.DataManager;
56
import com.intellij.openapi.application.Application;
@@ -101,6 +102,9 @@ String getId() {
101102
}
102103

103104
private void initializeAutoCreatedComponents() {
105+
warningLabel.setIcon(AllIcons.General.Warning);
106+
marginHelp.setIcon(AllIcons.Actions.Help);
107+
104108
chooseImageButton.addActionListener(e -> {
105109
CustomStickerChooser dialog = new CustomStickerChooser(
106110
Arrays.stream(ProjectManager.getInstance().getOpenProjects()).findFirst().orElse(

0 commit comments

Comments
 (0)