Sabre Raven appearing as normal Sabre

[seskritt]

The Sabre Raven is appearing with the name and image of a normal Sabre.

[peter-dolkens]

Will add this to my list to look at - am in the middle of moving half way around the world, so may be after the holidays, but thanks for bringing to my attention.

[seskritt]

Will add this to my list to look at - am in the middle of moving half way around the world, so may be after the holidays, but thanks for bringing to my attention.

When I have a some free time I'll take a stab at fixing it myself. Thank you for the update and good luck with your big move!

[seskritt]

The bug was caused by the name matching in the ParseShip method. Since it checks if a shipMatrix name exists in the hangar ship's name, "Sabre" was coming up as a match for "Sabre Raven". I've submitted a pull request #121

[mbetzer]

I opened a new issue (#124), but it might be the same as this.

[peter-dolkens]

It's actually meant to work through the shipMatrix sequentially, and the list is sorted by length descending, meaning the most exact match should always be the first one matched...

For some ships (Heartseeker) there may be a discrepancy between what it's called in ship matrix, and what it's called on the pledge screen which may be causing issues, but as far as I can see, the Sabre should have been working.

Will do some more testing

[peter-dolkens]

Potentially linked to #100

[peter-dolkens]

Can you give it a go now - if no one has any issues, I'll close this issue out next week