Skip to content
This repository was archived by the owner on Oct 28, 2020. It is now read-only.
This repository was archived by the owner on Oct 28, 2020. It is now read-only.

Update method not computing scroll offsets #663

@joshkg

Description

@joshkg

The issue I'm facing is that calling update changes the props for the instance, but does not seem to update the actual scroll behavior. Taking a look at the method:

update (updatedProps = null) {
this.instances.forEach((instance) => {
this.computeScrollOffsets(instance)
if (updatedProps) {
// eslint-disable-next-line no-unused-vars
for (const updatedProp in updatedProps) {
instance.props[updatedProp] = updatedProps[updatedProp]
}
}
})
return this
}

I can see that computeScrollOffsets is called BEFORE the props are updated. It seems to me that computing scroll offsets ought to be done AFTER changing the props.

Manually calling computeScrollOffsets after using update in my own implementation results in the desired change to scroll behavior.

I'm happy to submit a PR to move computeScrollOffsets below prop changes if this logic seems correct.

Incidentally, I found the issue where this code was introduced (#412) - I suspect the problem I'm seeing is hidden by the example where update is called on resize, where update is probably called multiple times as the browser resize event fires multiple times (thus recomputing the previous prop updates, but never recomputing the very last prop update).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions