"no_country_redirect" cookie should never expire (regression)

[mbc07]

This has been happening for a long while but I didn't have time to investigate before.

If you visit https://dolphin-emu.org, there's logic for detecting the browser locale and redirect the user to an appropriate, translated, subdomain (e.g. https://br.dolphin-emu.org), if we have one. When that redirection occurs, the user will also see an "You have been redirected to the (subdomain language here) version of the website based on your browser language preferences. If you prefer the English version, click here to go back". By clicking that link, a cookie named "no_country_redirect" is set, which prevents the locale redirection logic to trigger again on the next visit.

So far so good, but at some point, the expiry date for that cookie changed from a really long date in the future (can't remember now) to just 2 hours, which means that now the redirection logic is triggering in nearly all visits. Can we change that cookie back to having a really long expire date? AFAICT the maximum we can set is 400 days...

[mbc07]

Ok, according to this, the cookie indeed should have a duration of one year. It seems the logic is breaking somewhere else...