Add a duplicate button

Author: donadigo

src/AppInfoView.vala

@@ -20,6 +20,7 @@
 public class AppEditor.AppInfoView : Gtk.Box {
     public DesktopApp desktop_app { get; construct set; }
     public signal void removed ();
+    public signal void duplicate ();
 
     public string save_display_name {
         get {
@@ -211,14 +212,19 @@ public class AppEditor.AppInfoView : Gtk.Box {
         var open_source_button = new Gtk.Button.with_label (_("Open in Text Editor"));
         open_source_button.clicked.connect (on_open_source_button_clicked);
 
+        var duplicate_button = new Gtk.Button.with_label (_("Duplicate"));
+        duplicate_button.clicked.connect (() => duplicate ());
+
         var size_group = new Gtk.SizeGroup (Gtk.SizeGroupMode.HORIZONTAL);
         size_group.add_widget (save_button);
         size_group.add_widget (restore_defaults_button);
+        size_group.add_widget (duplicate_button);
         size_group.add_widget (open_source_button);
 
         var button_box = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 6);
         button_box.margin = 6;
         button_box.pack_start (open_source_button, false, false);
+        button_box.pack_start (duplicate_button, false, false);
         button_box.pack_end (save_button, false, false);
         button_box.pack_end (restore_defaults_button, false, false);
 
@@ -415,11 +421,7 @@ public class AppEditor.AppInfoView : Gtk.Box {
         try {
             desktop_app.open_default_handler (get_screen ());
         } catch (Error e) {
-            var dialog = new MessageDialog (_("Could Not Open This Entry"), e.message, "dialog-error");
-            dialog.add_button (_("Close"), Gtk.ResponseType.CLOSE);
-            dialog.show_all ();
-            dialog.run ();
-            dialog.destroy ();
+            MessageDialog.show_default_dialog (_("Could Not Open This Entry"), e.message, "dialog-error");
         }
     }
 

src/AppInfoViewSaver.vala

@@ -20,7 +20,8 @@
 public class AppEditor.AppInfoViewSaver : Object {
     public AppInfoView target { get; set; }
 
-    public static DesktopApp? create_new_local_app (AppCategory? category) {
+    // TODO: make these functions fully async
+    public static DesktopApp? create_new_local_app (AppCategory? category) throws Error {
         string lang = Intl.get_language_names ()[0];
 
         var key = new KeyFile ();
@@ -32,19 +33,43 @@ public class AppEditor.AppInfoViewSaver : Object {
             key.set_string_list (KeyFileDesktop.GROUP, KeyFileDesktop.KEY_CATEGORIES, categories);
         }
 
-        string path = AppDirectoryScanner.get_config_path ();
-
-        uint next_index = get_next_local_app_index (path);
-        string new_filename = Path.build_filename (path, "%s%u%s".printf (DesktopApp.LOCAL_APP_NAME_PREFIX, next_index, DesktopApp.LOCAL_APP_NAME_SUFFIX));
+        string config_path = AppDirectoryScanner.get_config_path ();
+        string new_filename = get_next_local_filename (config_path);
         try {
             key.save_to_file (new_filename);
 
             var app_info = new DesktopAppInfo.from_filename (new_filename);
             var desktop_app = new DesktopApp (app_info);
             return desktop_app;
         } catch (Error e) {
-            return null;
+            throw e;
+        }
+    }
+
+    public static DesktopApp? create_new_clone_app (DesktopApp app) throws Error {
+        string target_filename = app.info.get_filename ();
+        string contents;
+        try {
+            FileUtils.get_contents (target_filename, out contents);
+        } catch (FileError e) {
+            throw e;
+        }
+
+        string config_path = AppDirectoryScanner.get_config_path ();
+        string new_filename = get_next_local_filename (config_path);
+        var file = File.new_for_path (new_filename);
+        try {
+            var os = file.create (FileCreateFlags.NONE);
+            os.write_all (contents.data, null);
+            os.close ();
+
+            var app_info = new DesktopAppInfo.from_filename (new_filename);
+            var desktop_app = new DesktopApp (app_info);
+            return desktop_app;
+        } catch (Error e) {
+            throw e;
         }
+
     }
 
     public async void save () throws Error {
@@ -125,6 +150,11 @@ public class AppEditor.AppInfoViewSaver : Object {
         return str.escape ();
     }
 
+    private static string get_next_local_filename (string path) {
+        uint next_index = get_next_local_app_index (path);
+        return Path.build_filename (path, "%s%u%s".printf (DesktopApp.LOCAL_APP_NAME_PREFIX, next_index, DesktopApp.LOCAL_APP_NAME_SUFFIX));
+    }
+
     private static uint get_next_local_app_index (string path) {
         uint index = 1;
 

src/AppInfoViewStack.vala

@@ -19,6 +19,7 @@
 
 public class AppEditor.AppInfoViewStack : Gtk.Stack {
     public signal void view_removed (AppInfoView view);
+    public signal void duplicate_app (DesktopApp app);
 
     construct {
         transition_type = Gtk.StackTransitionType.SLIDE_UP_DOWN;
@@ -68,6 +69,7 @@ public class AppEditor.AppInfoViewStack : Gtk.Stack {
         if (widget == null) {
             widget = new AppInfoView (desktop_app);
             widget.removed.connect (() => view_removed (widget));
+            widget.duplicate.connect (() => duplicate_app (desktop_app));
             add (widget);
         }
 

src/MainWindow.vala

@@ -51,6 +51,7 @@ public class AppEditor.MainWindow : Gtk.Window {
 
         app_info_view_stack = new AppInfoViewStack ();
         app_info_view_stack.view_removed.connect (on_view_removed);
+        app_info_view_stack.duplicate_app.connect (on_duplicate_app);
 
         var show_hidden_label = new Gtk.Label (_("Show hidden entries"));
         show_hidden_label.get_style_context ().add_class ("h4");
@@ -262,6 +263,15 @@ public class AppEditor.MainWindow : Gtk.Window {
         app_source_list.remove_app (view.desktop_app);
     }
 
+    private void on_duplicate_app (DesktopApp desktop_app) {
+        try {
+            var new_app = AppInfoViewSaver.create_new_clone_app (desktop_app);
+            app_source_list.add_app (new_app, true);
+        } catch (Error e) {
+            MessageDialog.show_default_dialog (_("Could Not Duplicate %s").printf (desktop_app.get_display_name ()), e.message, "dialog-error");
+        }
+    }
+
     private void on_new_button_clicked () {
         search_entry.text = "";
 
@@ -271,8 +281,12 @@ public class AppEditor.MainWindow : Gtk.Window {
             current_category = current_view.desktop_app.get_main_category ();
         }
 
-        var new_app = AppInfoViewSaver.create_new_local_app (current_category);
-        app_source_list.add_app (new_app, true);
+        try {
+            var new_app = AppInfoViewSaver.create_new_local_app (current_category);
+            app_source_list.add_app (new_app, true);
+        } catch (Error e) {
+            MessageDialog.show_default_dialog (_("Could Not Create a New Application"), e.message, "dialog-error");
+        }
     }
 
     private void on_show_hidden_switch_active_changed () {

src/MessageDialog.vala

@@ -22,6 +22,14 @@ public class AppEditor.MessageDialog : Gtk.Dialog {
     public string secondary_text { get; construct set; }
     public string image_icon_name { get; construct set; }
 
+    public static void show_default_dialog (string primary_text, string secondary_text, string image_icon_name) {
+        var dialog = new MessageDialog (primary_text, secondary_text, image_icon_name);
+        dialog.add_button (_("Close"), Gtk.ResponseType.CLOSE);
+        dialog.show_all ();
+        dialog.run ();
+        dialog.destroy ();        
+    }
+
     public MessageDialog (string primary_text, string secondary_text, string image_icon_name) {
         Object (
             resizable: false,