pull_comment.created addressed by issue_comment.created or not ?

[equalsJeffH]

Are pull request comments covered by issue_comment.created -- ie are PR comments forwarded to the mailing list if the latter event is selected ? Or, might we need yet another template established for pull_comment.created in order to do so? I am guessing the latter is the case, based on what is being sent to the public-webauthn@ list via github.com/w3c/webauthn/.

thx

[dontcallmedom]

there are two types of "pull request comments":

• the ones that are made as comments on the PR itself — these are treated as part of issue_comment.created
• the ones that are made as comments on specific lines of the commits — these are "commit comments" which the tool doesn't handle at the moment; handling them would require a bit more work than just a new template (but probably not much more)

[equalsJeffH]

@dontcallmedom wrote:

there are two types of "pull request comments":

the ones that are made as comments on the PR itself — these are treated as part of issue_comment.created

yeah, thx, that's what I figured out by observation. Though, today, I made comments on a couple PRs that were not (as yet?) fwd'd to the public-webauthn@ list:

• Add credential type uaf w3c/webauthn#407 (comment)
• Add credential type uaf w3c/webauthn#407 (comment)
• Add uaf attestation format w3c/webauthn#408 (comment)

..so there's some issue(s) somewhere(s). I note that PR comments have been fwd'd to the public-webauthn@ list in the past, so I'm wondering why this behavior appeared today...

@dontcallmedom also wrote:

the ones that are made as comments on specific lines of the commits — these are "commit comments" which the tool doesn't handle at the moment; handling them would require a bit more work than just a new template (but probably not much more)

It would be very nice IMV to have the option to have such comments -- both individual line-comments, as well as PR "review (both summary and line) comments" -- fwd'd to a mailing list.

thanks,

=JeffH

[dontcallmedom]

@equalsJeffH wrote

Though, today, I made comments on a couple PRs that were not (as yet?) fwd'd to the public-webauthn@ list

Indeed, there seems to have been a problem with part of what the system expects from the github API around the time you sent these messages. I'm not sure if there is much that can be done about it.

It would be very nice IMV to have the option to have such comments -- both individual line-comments, as well as PR "review (both summary and line) comments" -- fwd'd to a mailing list.

right; I'll try to get to this soon, but of course, pull requests are very welcome if you feel like diving in this :)